[ui] Python Script Editor Improvements #2587
Conversation
| horizontalAlignment: Text.AlignHCenter | ||
| Layout.fillWidth: true | ||
| } | ||
| MSplitView { |
There was a problem hiding this comment.
This needs to be discussed but I wonder if it wouldn't be better to have the split view be horizontal instead of vertical... As such, it's is pretty much unusable unless we expand the Script Editor's tab, which may not be ideal.
There was a problem hiding this comment.
Thanks for your feedback @cbentejac, I do agree with how the widgets are placed in Meshroom at the moment, the best layout is a RowLayout.
Have reverted back in terms of Layout and I guess we can keep it till the time we have a better location/placement of Script Editor.
waaake
force-pushed
the
dev/PythonScriptEditor
branch
from
2bd93ff to
52b52b8
Compare
waaake
force-pushed
the
dev/PythonScriptEditor
branch
from
52b52b8 to
dd40d93
Compare
|
Thanks for the suggestions @yann-lty |
waaake
force-pushed
the
dev/PythonScriptEditor
branch
from
dd40d93 to
d0ecb8a
Compare
…xceptions ScriptEditorManager now also allows the code to be saved and retrieved back. Exceptions are now shown with a better output to the user.
ScriptEditor is now part of a ColumnLayout in an MSplitView allowing more control over what is being viewed.
Python syntax within the script editor is now highlighted making it easier to understand and write smaller code in it.
A Row Layout is more practical for using script editor with the current placement of meshroom GUI.
Updated Icons for ScriptEditor Script Editor shows a confirmation dialog before clearing history
waaake
force-pushed
the
dev/PythonScriptEditor
branch
from
d0ecb8a to
49052df
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2587 +/- ##
========================================
Coverage 69.93% 69.93%
========================================
Files 121 121
Lines 7088 7088
========================================
Hits 4957 4957
Misses 2131 2131 ☔ View full report in Codecov by Sentry. |
Description
ScriptEditor Improvements
Features list