Added Backdrop Node for Meshroom graph #2574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
added
majorFeature
and removed
feature request
waaake
force-pushed
the
dev/BackdropNode
branch
from
e5b1ba2 to
50d7003
Compare
cbentejac
reviewed
Oct 24, 2024
meshroom/core/desc.py
Outdated
Comment on lines
802
to
859
| class Backdrop(InputNode): | ||
| """ A Backdrop for other nodes. | ||
| """ | ||
|
|
||
| # The internal inputs' of Backdrop Node needs a Integer Field to determine the font size for the comment | ||
| internalInputs = [ | ||
| StringParam( | ||
| name="invalidation", | ||
| label="Invalidation Message", | ||
| description="A message that will invalidate the node's output folder.\n" | ||
| "This is useful for development, we can invalidate the output of the node when we modify the code.\n" | ||
| "It is displayed in bold font in the invalidation/comment messages tooltip.", | ||
| value="", | ||
| semantic="multiline", | ||
| advanced=True, | ||
| uidIgnoreValue="", # If the invalidation string is empty, it does not participate to the node's UID | ||
| ), | ||
| StringParam( | ||
| name="comment", | ||
| label="Comments", | ||
| description="User comments describing this specific node instance.\n" | ||
| "It is displayed in regular font in the invalidation/comment messages tooltip.", | ||
| value="", | ||
| semantic="multiline", | ||
| invalidate=False, | ||
| ), | ||
| IntParam( | ||
| name="fontSize", | ||
| label="Font Size", | ||
| description="The Font size for the User Comment on the Backdrop.", | ||
| value=12, | ||
| range=(6, 100, 1), | ||
| ), | ||
| FloatParam( | ||
| name="nodeWidth", | ||
| label="Node Width", | ||
| description="The Backdrop Node's Width.", | ||
| value=600, | ||
| range=None, | ||
| enabled=False # Hidden always | ||
| ), | ||
| FloatParam( | ||
| name="nodeHeight", | ||
| label="Node Height", | ||
| description="The Backdrop Node's Height.", | ||
| value=400, | ||
| range=None, | ||
| enabled=False # Hidden always | ||
| ), | ||
| ColorParam( | ||
| name="color", | ||
| label="Color", | ||
| description="Custom color for the node (SVG name or hexadecimal code).", | ||
| value="", | ||
| invalidate=False, | ||
| ) | ||
| ] | ||
|
|
There was a problem hiding this comment.
Is there a reason why we totally overwrite the internal inputs instead of using the ones from the parent class and adding "Font Size" to it?
With the current way, there's a lot of duplication and the "Node's Label" internal attribute is lost, which I think is a shame since we may want to name the backdrop itself, and not just use the "Comments" attribute. This would prevent having several backdrops named "Backdrop", "Backdrop2", "Backdrop3", and so on... if we want to name them. Similarly, the "Invalidation Message" is currently preserved although it has no impact anywhere so far.
| @@ -135,7 +139,7 @@ Item { | |||
| Keys.onPressed: { | |||
| if (event.key === Qt.Key_F) { | |||
| fit() | |||
| } else if (event.key === Qt.Key_Delete) { | |||
| } else if (event.key === Qt.Key_Delete || event.key === Qt.Key_Backspace) { // Backspace supports both Windows and MacOS Keyboards | |||
There was a problem hiding this comment.
Not directly related to this, but when a backdrop contains nodes, is there no way to remove the background only and not the background AND everything it contains? (that's a real question, not necessarily a change request)
waaake
force-pushed
the
dev/BackdropNode
branch
2 times, most recently
from
0a4bf9f to
e73c4df
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2574 +/- ##
===========================================
- Coverage 69.93% 69.92% -0.02%
===========================================
Files 121 122 +1
Lines 7088 7151 +63
===========================================
+ Hits 4957 5000 +43
- Misses 2131 2151 +20 ☔ View full report in Codecov by Sentry. |
Attribute factory serves as a common place to initialize and group attributes and define an accessor to be able to retrieve the attributes
Backdrop Node serves as a Graphical Node allowing only internal attributes to be listed and can be serialized
Added Backdrop Node descriptor which is a derived Incomputable Node with Resizable Attribute Traits
The Loader allows loading Backdrop Component for backdrop nodes and Standard Node component for other nodes
…nstructor for Node Types
waaake
force-pushed
the
dev/BackdropNode
branch
from
e73c4df to
cf16a9d
Compare
…at a given index With the change in nodeRepeater to hold the Loader instead of active delegate, fetching the item at a given index involves getting the loader at index and then it's item. This function allows easy access to the item directly.
…m rather than the loader delegate
…tem rather than the loader delegate
waaake
force-pushed
the
dev/BackdropNode
branch
from
cf16a9d to
e54d1a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCSR-1194
Feature Request
Minor Fix