Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-1748] Remove sensitive data from Pubsub loggers #544

Merged

Conversation

Bendakh
Copy link
Contributor

@Bendakh Bendakh commented Nov 6, 2023

Description

Through this PR, we removed some sensitive data from the pubsub loggers.

@Bendakh Bendakh changed the title [NO-6480] Remove sensitive data from Pubsub loggers [NO-1748] Remove sensitive data from Pubsub loggers Nov 7, 2023
Copy link
Contributor

@qhdinh qhdinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we only wanted to hide the sensitive data in the payload. Here we log 0 data in the PusSub payload, so how to debug?

@qhdinh
Copy link
Contributor

qhdinh commented Nov 7, 2023

There is also data at the end of emit()?

return topic.publishMessage({
      json: data,
      attributes: { ...attributes, ...opts.metadata },
      ...opts.options?.messageOptions,
    });

@Bendakh Bendakh requested a review from amarlankri November 8, 2023 09:46
@Bendakh
Copy link
Contributor Author

Bendakh commented Nov 8, 2023

I thought we only wanted to hide the sensitive data in the payload. Here we log 0 data in the PusSub payload, so how to debug?

In the investigation I saw that we want to remove the data and payloads

Copy link

@amarlankri amarlankri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bendakh!

@g-ongenae g-ongenae merged commit 28364b9 into algoan:master Nov 8, 2023
4 checks passed
@algoanbot
Copy link

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants