[HTTP-EXCEPTION-FILTER] Add option to mask headers #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
na-ji
approved these changes
Jun 21, 2024
amarlankri
approved these changes
Jun 21, 2024
meriamBenSassi
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an option to mask the headers of logged when the server responds with an error code (>= 400).
The options are the same as the one used on
@algoan/nestjs-logging-interceptor.This PR is using the same logic as #822 for the mask of the header (
maskHeadersprivate method).Motivation and Context
The headers may contain sensitive data. Especially, an API key header or an authorization header which may contain a JWT with numerous sensitive data encoded, readable by anyone once decoded. So, the
http-exception-filtershould provide a way to mask those sensitive data in the logs.Types of changes