Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] apply log masks to http exception body #817

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[FEAT] apply log masks to http exception body #817

merged 1 commit into from
Nov 28, 2023

Conversation

LeKer29
Copy link
Contributor

@LeKer29 LeKer29 commented Nov 28, 2023

Description

This pull request aims to apply log masks to HTTP exception body.

Motivation and Context

For HTTP exceptions, the request body is displayed in the logs (error or warn). Thus the masking options should be applied to the body.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@LeKer29 LeKer29 self-assigned this Nov 28, 2023
@LeKer29 LeKer29 added the enhancement New feature or request label Nov 28, 2023
amarlankri
amarlankri approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@amarlankri amarlankri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @LeKer29 👌

@g-ongenae g-ongenae merged commit c4d1205 into algoan:master Nov 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarlankri amarlankri amarlankri approved these changes

@g-ongenae g-ongenae g-ongenae approved these changes

@meriamBenSassi meriamBenSassi Awaiting requested review from meriamBenSassi

Assignees

@LeKer29 LeKer29

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeKer29 @g-ongenae @amarlankri