Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEPS] Replace delay by node setTimeout #785

Merged
merged 2 commits into from
Oct 26, 2023
Merged

[DEPS] Replace delay by node setTimeout #785

merged 2 commits into from
Oct 26, 2023

Conversation

g-ongenae
Copy link
Member

Description

Replace node module delay in test by native node setTimeout.

Motivation and Context

The fewer dependencies, the less maintenance needed…

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@g-ongenae g-ongenae added the dependencies Pull requests that update a dependency file label Oct 26, 2023
@g-ongenae g-ongenae self-assigned this Oct 26, 2023
@g-ongenae g-ongenae merged commit 778c670 into algoan:master Oct 26, 2023
4 checks passed
@g-ongenae g-ongenae deleted the fixture/replace-delay-by-settimeout branch October 26, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeKer29 LeKer29 LeKer29 approved these changes

@meriamBenSassi meriamBenSassi Awaiting requested review from meriamBenSassi

@amarlankri amarlankri Awaiting requested review from amarlankri

Assignees

@g-ongenae g-ongenae

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-ongenae @LeKer29