Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Allow nestjs peer dependencies to be >= 8 and @algoan/pubsub to be >= 4 #782

Merged

Conversation

g-ongenae
Copy link
Member

Description

Allow nestjs peer dependencies to be >= 8 and @algoan/pubsub to be >= 4 for the packages:

  • google-pubsub-client
  • google-pubsub-microservices

Motivation and Context

This allows to update a nestjs application using those dependencies to be update to v9 or higher. Linked issue: #772

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@amarlankri amarlankri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I am not sure it is a good practice to be so permissive 🤔 If a new major version is released for a dependency, it could introduce breaking change for our packages, right?

@g-ongenae
Copy link
Member Author

To be honest, I am not sure it is a good practice to be so permissive 🤔 If a new major version is released for a dependency, it could introduce breaking change for our packages, right? - @amarlankri

I don't find any best practice on the subject. IMHO, we should only limit the range if we're sure that it is not compatible, not in the case it may be incompatible. It is up to the end user of the package to know that it may be incompatible with new version of the peer dependencies.

Also, I'm actually confused this PR is necessary since looking at the semver validation from npmjs, it is the same output whether we write it as >= 1.x.x or >= 1. 87 compatible versions, in the case of @nestjs/core, today.

@g-ongenae g-ongenae merged commit 11d145b into algoan:master Oct 25, 2023
4 checks passed
@g-ongenae g-ongenae deleted the fixture/allow-peer-deps-nestjs-sup-8 branch October 25, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants