Merge pull request #368 from Bendakh/fix/NoPossibilityToChangeTheLang…

…uage [TP-10326] Make language customizable
algoan · Oct 13, 2022 · e7e55a8 · e7e55a8
2 parents ebaa7b7 + 8fd4e6f
commit e7e55a8
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/src/aggregator/services/aggregator.service.spec.ts b/src/aggregator/services/aggregator.service.spec.ts
@@ -5,7 +5,7 @@ import { AppModule } from '../../app.module';
 import { Connection } from '../interfaces/budget-insight.interface';
 import { mockAccount, mockTransaction, mockCategory } from '../interfaces/budget-insight-mock';
 import { AggregatorService } from './aggregator.service';
-import { BudgetInsightClient } from './budget-insight/budget-insight.client';
+import { BudgetInsightClient, ClientConfig } from './budget-insight/budget-insight.client';
 
 describe('AggregatorService', () => {
   let service: AggregatorService;
@@ -97,6 +97,20 @@ describe('AggregatorService', () => {
     );
   });
 
+  it('should create the webviewUrl base on the callbackUrl with a custom language', () => {
+    const config: ClientConfig = {
+      clientId: 'budgetInsightClientId',
+      clientSecret: 'budgetInsightClientSecret',
+      baseUrl: 'https://fake-budget-insights.com/2.0',
+      language: 'en',
+    };
+
+    const url: string = service.generateRedirectUrl('callbackUrl', config);
+    expect(url).toBe(
+      'https://fake-budget-insights.com/2.0/auth/webview/en/connect?client_id=budgetInsightClientId&redirect_uri=callbackUrl&response_type=code&state=&types=banks',
+    );
+  });
+
   it('should get the accounts', async () => {
     const spy = jest.spyOn(client, 'fetchBankAccounts').mockReturnValue(Promise.resolve([mockAccount]));
     const token = 'token';

diff --git a/src/aggregator/services/aggregator.service.ts b/src/aggregator/services/aggregator.service.ts
@@ -59,7 +59,9 @@ export class AggregatorService {
   public generateRedirectUrl(callbackUrl: string, clientConfig?: ClientConfig): string {
     const config: ClientConfig = this.budgetInsightClient.getClientConfig(clientConfig);
 
-    return `${config.baseUrl}/auth/webview/fr/connect?client_id=${config.clientId}&redirect_uri=${callbackUrl}&response_type=code&state=&types=banks`;
+    const language = config.language ?? 'fr';
+
+    return `${config.baseUrl}/auth/webview/${language}/connect?client_id=${config.clientId}&redirect_uri=${callbackUrl}&response_type=code&state=&types=banks`;
   }
 
   /**

diff --git a/src/aggregator/services/budget-insight/budget-insight.client.ts b/src/aggregator/services/budget-insight/budget-insight.client.ts
@@ -31,6 +31,7 @@ export interface ClientConfig {
   clientSecret: string;
   baseUrl: string;
   nbOfMonths?: number;
+  language?: string;
 }
 
 /**