Update NFS client helm chart #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexellis
reviewed
Jul 8, 2022
Add alias for the original name Rename the chart Fix helm url Update info msg Signed-off-by: Czékus Máté <mate@picloud.hu>
Shikachuu
force-pushed
the
update-nfs-client
branch
from
c61fa85 to
5a82e34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add alias for the original name
Rename the chart
Fix helm url
Update info msg
Signed-off-by: Czékus Máté mate@picloud.hu
Description
The
nfs-client-provisionerchart was so outdated it has been moved twice and renamed since thehttps://charts.helm.sh/stabledeprecation.I also added the original name (
nfs-client-provisioner) to maintain backward compatibility.Motivation and Context
design/approvedby a maintainer (required) Notice: the stable Helm charts have been deprecated, new alternatives are required #274Closes Confused about
nfs-provisionerapp #480 with the new alias.How Has This Been Tested?
By running
ark install nfs-subdir-external-provisionerandark install nfs-client-provisioner, after that check the helm releases.I know it sounds weird, but the chart itself functionally has not changed, nor the values.
Are you a GitHub Sponsor yet (Yes/No?)
Types of changes
Documentation
./arkade get -o markdown./arkade install --helpChecklist:
git commit -sAlso in the changes there is a removed arm check, since the chart has arm v7 and arm64 binaries.
I also tested this on an arm64 cluster.