Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bshow next transaction time when sending message #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

duy
Copy link
Contributor

@duy duy commented Sep 26, 2014

  • add nextTransactionTime variable to the client to store the next transaction absolute time
  • show when next transaction will happen in the "Created new outbox..." message
  • remove second decimals from "Next network transaction..." log message

 * add nextTransactionTime variable to the client to store the next transaction absolute time
 * show when next transaction will happen in the "Created new outbox..." message
 * remove second decimals from "Next network transaction..." log message
@burdges
Copy link
Contributor

burdges commented Nov 28, 2014

I suspect this patch does not provide the information intended :

Pond's next transaction might not send the message you've just "sent" either because you've multiple messages in the queue already or (I think) even because your next transaction is a fetch not a send.

In principle, you could reasonably display this time if (a) no messages are currently in the queue and (b) the next transaction would be a send. If (a) fails, maybe you'd want to say how many messages are ahead of it in the queue. If only (b) fails, then maybe you'd want to say "approximately" nextTransactionTime + 5min.

I donno if @agl had other concerns with this patch besides those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants