Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doing something with boolean returned by await method #68

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

BertScholten
Copy link
Member

Sonar indicated this as a bug. It's not really the way we're using it: we don't really care if there was a signal or if the wait time is over, we act the same anyway. But for debugging purposes it might be nice to log this, so added this information as a trace.

Sonar indicated this as a bug. It's not really the way we're using it: we don't really care if there was a signal or if the wait time is over, we act the same anyway. But for debugging purposes it might be nice to log this, so added this information as a trace.
@BertScholten BertScholten requested a review from Hilbrand December 5, 2023 09:56
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BertScholten BertScholten merged commit 0ee3c2c into aerius:main Dec 5, 2023
1 check passed
@BertScholten BertScholten deleted the sonar_issue branch December 5, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants