[MWPW-163793] Dispatch analytics events for Compress PDF #192
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
sanjayms01
reviewed
Jan 10, 2025
| this.block.dispatchEvent(new CustomEvent(unityConfig.trackAnalyticsEvent, { detail: { event: 'uploaded' } })); | ||
| } | ||
|
|
||
| async multiFileUpload(fileCount, eventName) { | ||
| this.block.dispatchEvent( | ||
| new CustomEvent( | ||
| unityConfig.trackAnalyticsEvent, | ||
| { detail: { event: eventName } }, | ||
| { detail: { event: eventName, data: {count: fileCount}} }, |
There was a problem hiding this comment.
fileCount data is already being passed below when dispatching the multifile analytics event so believe this can be removed from here. This was tracked as a separate event based on analytics team wanting to track a new event for this. If this has since changed and you have some additional context for this, let's sync on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR enhances the analytics events dispatched to provide relevant data on the consumer side.
Resolves: MWPW-163793
Test URLs:
Before: https://stage--dc--adobecom.hlx.page/acrobat/online/test/compress-pdf?unitylibs=stage
After: https://stage--dc--adobecom.hlx.page/acrobat/online/test/compress-pdf?unitylibs=mwpw-163792-analytics
URL for PSI check: https://mwpw-163792-analytics--unity--adobecom.hlx.page/drafts/ruchika/remove-background?martech=off