MWPW-165152: Splash screen / content nav URL handling #129
+48
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yesil
requested changes
Jan 13, 2025
| super.connectedCallback(); | ||
| } | ||
|
|
||
| handleInitialPageLoad() { |
There was a problem hiding this comment.
handleInitialPageLoad doesn't seem to be used.
| @@ -68,6 +69,13 @@ class MasSideNav extends LitElement { | |||
| } | |||
| `; | |||
|
|
|||
| navigateToSplash() { | |||
| const url = new URL(window.location.href); | |||
There was a problem hiding this comment.
with the state manager, the history/url management should be consolidated into a single location as a side-effect or reaction to state update.
I think it should be in navigateToPage.
| const pageParam = url.searchParams.get('page'); | ||
|
|
||
| const initialPage = | ||
| pageParam === 'welcome' |
There was a problem hiding this comment.
in the absence of search query in the URL, the pageParam should be set to welcome so that the welcome page has always the same url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves URL handling and navigation between splash screen and content navigation, specifically introduces the following criteria:
page=welcomesearchParam is added to URL (query and path are kept for context).page=welcomeis removed from URL.?page=welcome, user is taken directly to Splash screen (assuming it's intended).This allows querying data within studio with URL params bypassing splash screen while letting the user navigate to splash screen when intended.
Resolves MWPW-165152
Test URLs: