Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poc #3

Merged
merged 86 commits into from
Mar 25, 2024
Merged

Poc #3

merged 86 commits into from
Mar 25, 2024

Conversation

qiyundai
Copy link
Collaborator

@qiyundai qiyundai commented Mar 25, 2024 •
edited
Loading

qiyundai added 30 commits March 13, 2024 16:04
@qiyundai
remove empty line
065bcfc
@qiyundai
wip
d75a758
@qiyundai
fetch approach working
6168f02
@qiyundai
img replacement wip
eaaa868
@qiyundai
populating page with flatten data
578052b
@qiyundai
leaving console log for debugging
2e723d2
@qiyundai
more console log for debug
6652c4a
@qiyundai
fixing img swapping
0755671
@qiyundai
testing new img swapping code on branch
33a83f6
@qiyundai
cleaner 404 redirect
df14272
@qiyundai
lint
16ee14a
@qiyundai
fixing lana log
c68ec81
@qiyundai
added custom events-form, which allows a 3rd row input to designate c…
2de49d0 
…ustom action endpoint
@qiyundai
testing with dx client id
ced1891
@qiyundai
Pre-filling form with mock
d04281d
@qiyundai
testing with milo clientId
a081528
@qiyundai
add console log for debugging
9f01dcb
@qiyundai
Merge branch 'events-form' into poc
ff6f4d0
@qiyundai
joining branches on POC
b1bbc96
@qiyundai
WIP
174a4c7
@qiyundai
speaker and host addition
26aa0f6
@qiyundai
use adobedotcomdx clientID
4dabd29
@qiyundai
tags layout fix
7ec7785
@qiyundai
for content replacement works
82ace21
@qiyundai
wip
42a5b8e
@qiyundai
memoized caas API fetch
c3a1f72
@qiyundai
test on branch
1d0e04e
@qiyundai
Update events-form.js
a6481f5
@qiyundai
try catch getProfile
2f2d05c
@qiyundai
small layout fix
fc91463
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Mar 25, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Mar 25, 2024 •
edited
Loading

Page Scores Audits Google
/hub/?milolibs=events-poc&martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/t3/event/03-12-2024/chicago/il/adobe-events-seminar?milolibs=events-poc&martech
=off		 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@apganapa-adobe apganapa-adobe merged commit 5ff39f4 into stage Mar 25, 2024
5 of 6 checks passed
shkhan91
shkhan91 reviewed Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@shkhan91 shkhan91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shkhan91 shkhan91 shkhan91 left review comments

@apganapa-adobe apganapa-adobe apganapa-adobe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qiyundai @shkhan91 @apganapa-adobe