MWPW-151250: Implemented filtering cards by partner level #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #14 +/- ##
==========================================
- Coverage 85.28% 83.73% -1.55%
==========================================
Files 8 8
Lines 2460 2509 +49
==========================================
+ Hits 2098 2101 +3
- Misses 362 408 +46 ☔ View full report in Codecov by Sentry. |
zagi25
requested changes
Jun 3, 2024
Ben-Zahler
changed the title
zagi25
approved these changes
Jun 3, 2024
Ben-Zahler
reviewed
Jun 4, 2024
eds/components/PartnerCards.js
Outdated
| try { | ||
| let cookies = document.cookie.split(';').map(cookie => cookie.trim()); | ||
| let partnerDataCookie = cookies.find(cookie => cookie.startsWith('partner_data=')); | ||
| if (!partnerDataCookie) return ''; |
There was a problem hiding this comment.
I think we need a public tag to handle this case, but I did not create it yet...
aem-code-sync
bot
temporarily deployed
to
mwpw-151250-partner-lvl-cards
…s; added portal and component specific collectionTags
aem-code-sync
bot
temporarily deployed
to
mwpw-151250-partner-lvl-cards
aem-code-sync
bot
temporarily deployed
to
mwpw-151250-partner-lvl-cards
aem-code-sync
bot
temporarily deployed
to
mwpw-151250-partner-lvl-cards
Ben-Zahler
approved these changes
Jun 13, 2024
aem-code-sync
bot
temporarily deployed
to
mwpw-151250-partner-lvl-cards
aem-code-sync
bot
temporarily deployed
to
mwpw-151250-partner-lvl-cards
zagi25
reviewed
Jun 14, 2024
zagi25
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-151250 and MWPW-151916
***Example with collection tags authored ('public' tag for complexQuery will be added whether the cooke is set or not; if the cookie is set, an additional tag for complexQuery, depending on the cookie/level, will be added. For collectionsTags, the portal specific tag (caas:adobe-partners/spp), component specific tag (caas:adobe-partners/collections/news), and all authored tags should be added):
Before:
https://stage--dx-partners--adobecom.hlx.page/solutionpartners/drafts/dragana/partner-news-collection-tags
After:
https://mwpw-151250-partner-lvl-cards--dx-partners--adobecom.hlx.page/solutionpartners/drafts/dragana/partner-news-collection-tags
***Without collection tags authored:
Before:
https://stage--dx-partners--adobecom.hlx.page/solutionpartners/drafts/dragana/partner-news
After:
https://mwpw-151250-partner-lvl-cards--dx-partners--adobecom.hlx.page/solutionpartners/drafts/dragana/partner-news
***Example of the page with an incorrect portal (complexQuery will not be added, and for collectionTags if not authored caas:adobe-partners/${portal} will not be added:
Before: https://stage--dx-partners--adobecom.hlx.page/SPP/drafts/dragana/partner-news
After: https://mwpw-151250-partner-lvl-cards--dx-partners--adobecom.hlx.page/SPP/drafts/dragana/partner-news
Keep in mind that partner_data cookie needs to be set manually for now.