Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-155099 - renew banner update #39

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

Copy link

aem-code-sync bot commented Aug 12, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Aug 12, 2024

Page Scores Audits Google
M /channelpartners/?georouting=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /channelpartners/?georouting=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.15%. Comparing base (65f0abb) to head (9579676).
Report is 5 commits behind head on stage.

Files Patch % Lines
edsdme/scripts/utils.js 55.55% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage      #39      +/-   ##
==========================================
- Coverage   81.91%   81.15%   -0.77%     
==========================================
  Files           8        8              
  Lines        2793     2802       +9     
==========================================
- Hits         2288     2274      -14     
- Misses        505      528      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ben-Zahler
Copy link
Collaborator

@draganatrajkovic since this does not include announcements, it may be smart to use a simple page for before/after so the Lighthouse scores are better.

@draganatrajkovic draganatrajkovic merged commit b674a6f into stage Aug 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants