Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-155391: Swap footer logic #38

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

zagi25
Copy link
Collaborator

@zagi25 zagi25 commented Aug 12, 2024

Feature:

  • If user is member he will get protected footer.
  • Protected and public footer can be authored in metadata (footer-soruce for public and footer-loggedin-source for protected)

Resolves: MWPW-155391

LINKS:
Before:

After:

Copy link

aem-code-sync bot commented Aug 12, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Aug 12, 2024

Page Scores Audits Google
/channelpartners/?georouting=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.45%. Comparing base (fd29022) to head (c8d7471).

Files Patch % Lines
edsdme/scripts/utils.js 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage      #38      +/-   ##
==========================================
- Coverage   81.62%   81.45%   -0.17%     
==========================================
  Files           8        8              
  Lines        2775     2793      +18     
==========================================
+ Hits         2265     2275      +10     
- Misses        510      518       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cod17828
Copy link
Collaborator

@zagi25 nala test pass locally for pr branch

@Ben-Zahler Ben-Zahler merged commit 65f0abb into stage Aug 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants