Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mwpw 155385 personalisation #36

Merged
merged 7 commits into from
Aug 16, 2024
Merged

Mwpw 155385 personalisation #36

merged 7 commits into from
Aug 16, 2024

Conversation

zagi25
Copy link
Collaborator

@zagi25 zagi25 commented Aug 9, 2024

Personalization feature:

  • Placeholder personalization: currently supports only $firsName placeholder, this placeholder will be replaced with a value from partner_data cookie, if cookie is missing placeholder and element containing it will be removed
  • Block/Section personalization: please refer to the ticket for all currently supported personalization classes. Block/Section will be removed from the page if all personalization conditions are false.

Resolves: MWPW-155385

LINKS:
Before:

After:

Copy link

aem-code-sync bot commented Aug 9, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch

Note: PSI checks are disabled due to site authentication. Please utilize your org/client side GHA PSI implementation

Commits

Copy link

aem-code-sync bot commented Aug 9, 2024

Page Scores Audits Google
/channelpartners/drafts/ratko/personalization?georouting=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-155385-personalisation August 9, 2024 10:30 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 72.80000% with 34 lines in your changes missing coverage. Please review.

Project coverage is 79.74%. Comparing base (6372409) to head (b0192a9).

Files Patch % Lines
edsdme/scripts/personalization.js 65.16% 31 Missing ⚠️
edsdme/scripts/utils.js 91.17% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage      #36      +/-   ##
==========================================
- Coverage   80.54%   79.74%   -0.81%     
==========================================
  Files           8        9       +1     
  Lines        2802     2927     +125     
==========================================
+ Hits         2257     2334      +77     
- Misses        545      593      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

edsdme/scripts/utils.js Outdated Show resolved Hide resolved
@cod17828
Copy link
Collaborator

@zagi25 nala test pass locally for pr branch

@Ben-Zahler
Copy link
Collaborator

@zagi25 proposal: can weadd CSS rules to intially show the public parts and hide all others personalised content?
I think this would improve the loading experience and can have a positive impact on SEO of the public page.

@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-155385-personalisation August 13, 2024 10:39 Inactive
@zagi25 zagi25 requested a review from Ben-Zahler August 13, 2024 10:53
@zagi25 zagi25 merged commit d434af0 into stage Aug 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants