Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-155099 - renew banner #31

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Conversation

draganatrajkovic
Copy link
Collaborator

@draganatrajkovic draganatrajkovic commented Aug 5, 2024

Resolves: MWPW-155099

  • In order to test this, accountAnniversary in the partner_data cookie must be set
  • if the paths for different banners are set in metdata.xlsx, they will be used; otherwise the default path will be /edsdme/partners-shared/fragments/${banner-type} with a locale prefix if the country is not the US
  • currently, there are three types of banners: to recover a suspended account (active 90 days after expiration), for an account which expires in the next 24 hours, and for an account which expires in the next 30 days
  • mobile design is coverd

LINKS:

US page:
Before: https://stage--dme-partners--adobecom.hlx.page/channelpartners/drafts/dragana/announcements
After: https://mwpw-155099-renew-banner--dme-partners--adobecom.hlx.page/channelpartners/drafts/dragana/announcements

Example:
Screenshot 2024-08-05 at 16 21 38

DE page:
Before: https://stage--dme-partners--adobecom.hlx.page/de/channelpartners/drafts/dragana/announcements
After: https://mwpw-155099-renew-banner--dme-partners--adobecom.hlx.page/de/channelpartners/drafts/dragana/announcements

Example:
Screenshot 2024-08-05 at 16 26 59

Copy link

aem-code-sync bot commented Aug 5, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Aug 5, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 41.66667% with 42 lines in your changes missing coverage. Please review.

Project coverage is 81.28%. Comparing base (2754458) to head (8e6a563).

Files Patch % Lines
edsdme/scripts/utils.js 38.23% 42 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage      #31      +/-   ##
==========================================
- Coverage   81.40%   81.28%   -0.13%     
==========================================
  Files           7        7              
  Lines        2614     2682      +68     
==========================================
+ Hits         2128     2180      +52     
- Misses        486      502      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

edsdme/scripts/utils.js Outdated Show resolved Hide resolved
edsdme/scripts/utils.js Outdated Show resolved Hide resolved
edsdme/scripts/utils.js Outdated Show resolved Hide resolved
edsdme/scripts/utils.js Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to mwpw-155099-renew-banner August 7, 2024 08:30 Inactive
@draganatrajkovic draganatrajkovic merged commit 8c1cdd9 into stage Aug 7, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants