Smoke Tests #176

sashaCodeTest · 2025-01-09T09:23:36Z

ticket link: https://jira.corp.adobe.com/browse/MWPW-164551
testing url: https://mwpw-164551-smoke-tests--dme-partners--adobecom.hlx.page/channelpartners/

aem-code-sync · 2025-01-09T09:23:39Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

077e1ec ✅ (latest)
9bc685b ✅
849eaad ✅
e2b9c37 ✅
a11a124 ✅
67fe3f2 ✅
06395e5 ✅
565cda4 ✅
187e064 ✅
bfc9068 ✅
3ea522e ✅
ee63087 ✅
2a1a70e ✅
f77a56c ✅
0088a32 ✅
42c9c90 ✅

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dme-partners/nala/blocks/smoke-test/smoke.test.js

Lines 133 to 134 in 565cda4

    
             features[4].data.expectedPublicPageURL 
        
           );

🚫 [eslint] <spaced-comment> _{reported by reviewdog 🐶}
Expected exception block, space or tab after '//' in comment.

dme-partners/nala/blocks/smoke-test/smoke.test.js

Line 137 in 565cda4

//@user-redirection-emea-smoke-test

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dme-partners/nala/blocks/smoke-test/smoke.test.js

Lines 142 to 143 in 565cda4

    
             `${features[5].data.signInButtonInternationalText}` 
        
           );

🚫 [eslint] <spaced-comment> _{reported by reviewdog 🐶}
Expected exception block, space or tab after '//' in comment.

dme-partners/nala/blocks/smoke-test/smoke.test.js

Line 144 in 565cda4

//click on sign in button

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dme-partners/nala/blocks/smoke-test/smoke.test.js

Lines 154 to 155 in 565cda4

    
             features[5].data.expectedPublicPageURL 
        
           );

🚫 [eslint] <spaced-comment> _{reported by reviewdog 🐶}
Expected exception block, space or tab after '//' in comment.

dme-partners/nala/blocks/smoke-test/smoke.test.js

Line 158 in 565cda4

//@user-redirection-jp-smoke-test

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dme-partners/nala/blocks/smoke-test/smoke.test.js

Lines 163 to 164 in 565cda4

    
             `${features[6].data.signInButtonInternationalText}` 
        
           );

🚫 [eslint] <spaced-comment> _{reported by reviewdog 🐶}
Expected exception block, space or tab after '//' in comment.

dme-partners/nala/blocks/smoke-test/smoke.test.js

Line 165 in 565cda4

//click on sign in button

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dme-partners/nala/blocks/smoke-test/smoke.test.js

Lines 174 to 175 in 565cda4

    
             features[6].data.expectedPublicPageURL 
        
           );

🚫 [eslint] <spaced-comment> _{reported by reviewdog 🐶}
Expected exception block, space or tab after '//' in comment.

dme-partners/nala/blocks/smoke-test/smoke.test.js

Line 178 in 565cda4

//@search-page-validation-smoke-test

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dme-partners/nala/blocks/smoke-test/smoke.test.js

Lines 183 to 184 in 565cda4

    
             `${features[7].data.signInButtonInternationalText}` 
        
           );

🚫 [eslint] <spaced-comment> _{reported by reviewdog 🐶}
Expected exception block, space or tab after '//' in comment.

dme-partners/nala/blocks/smoke-test/smoke.test.js

Line 185 in 565cda4

//click on sign in button

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dme-partners/nala/blocks/smoke-test/smoke.test.js

Lines 194 to 195 in 565cda4

    
             features[7].data.expectedPublicPageURL 
        
           );

🚫 [eslint] <spaced-comment> _{reported by reviewdog 🐶}
Expected exception block, space or tab after '//' in comment.

dme-partners/nala/blocks/smoke-test/smoke.test.js

Line 198 in 565cda4

//@announcement-page-validation-smoke-test

🚫 [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

dme-partners/nala/blocks/smoke-test/smoke.test.js

Lines 203 to 204 in 565cda4

    
             `${features[7].data.signInButtonInternationalText}` 
        
           );

🚫 [eslint] <spaced-comment> _{reported by reviewdog 🐶}
Expected exception block, space or tab after '//' in comment.

dme-partners/nala/blocks/smoke-test/smoke.test.js

Line 205 in 565cda4

//click on sign in button

codecov-commenter · 2025-01-09T09:25:56Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.12%. Comparing base (b42c8e3) to head (077e1ec).
Report is 8 commits behind head on stage.

Additional details and impacted files

@@            Coverage Diff             @@
##            stage     #176      +/-   ##
==========================================
+ Coverage   81.01%   81.12%   +0.10%     
==========================================
  Files          12       12              
  Lines        3508     3507       -1     
==========================================
+ Hits         2842     2845       +3     
+ Misses        666      662       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cod17828 · 2025-01-09T10:18:16Z

nala/blocks/smoke-test/smoke.page.js

+    );
+
+    const downloadButton = await shadowRoot.$(
+      'sp-action-button[href="https://partners.stage.adobe.com/channelpartnerassets/assets/public/public_1/scanning_documents_into_pdf_files--ar.pdf?download"]',


change selector to find first a element that has download attribute for example

cod17828 · 2025-01-09T10:22:17Z

nala/blocks/smoke-test/smoke.test.js

+    });
+
+    await test.step('Find a row in assets list and click on download', async () => {
+      // await smokeTest.searchFirstAsset.click();


remove unused comment

cod17828 · 2025-01-09T10:24:16Z

nala/blocks/smoke-test/smoke.test.js

+    await test.step('Sing In, verify user redirection', async () => {
+      // entering user email and password
+      await signInSmokeTest.signIn(page, `${features[6].data.partnerLevel}`);
+      await page.waitForTimeout(10000);


change await function to wait for element on page, or document to be loaded

…tners into MWPW-164551-smoke-tests

Ben-Zahler · 2025-01-10T16:18:24Z

nala/blocks/smoke-test/smoke.page.js

+    this.signInButton = page.locator('.feds-signIn');
+    this.GNav = page.locator('.feds-topnav');
+    this.profileIcon = page.locator('.feds-profile-button');
+    this.priceList = page.locator('a[href="https://partners.stage.adobe.com/na/channelpartners/home/pricelists/"]');


I don't think this is this going to work on prod, right?
We should find a way that the smoke tests pass on prod and on stage

aem-code-sync · 2025-01-13T10:14:17Z

	Page	Scores	Audits
📱	/channelpartners/
🖥️	/channelpartners/

Kristijan Vizi and others added 9 commits October 18, 2024 13:10

Testing pop-up selector timeout

42c9c90

Testing pop-up selector timeout

0088a32

Testing pop-up selector timeout

f77a56c

Testing pop-up selector timeout

2a1a70e

Testing pop-up selector timeout

ee63087

Testing pop-up selector timeout

3ea522e

Sync nala branch with stage

bfc9068

Testing region selectors

187e064

Smoke Tests

565cda4

sashaCodeTest added the testing-nala-tests label Jan 9, 2025

github-actions bot reviewed Jan 9, 2025

View reviewed changes

sashaCodeTest requested review from Ben-Zahler, SonjaPopovic, cod17828 and dejanpreradovic January 9, 2025 09:24

Lint fix

06395e5

aem-code-sync bot temporarily deployed to MWPW-164551-smoke-tests January 9, 2025 09:42 Inactive

Merge branch 'nala' into MWPW-164551-smoke-tests

67fe3f2

aem-code-sync bot temporarily deployed to MWPW-164551-smoke-tests January 9, 2025 10:05 Inactive

cod17828 added testing-nala-tests and removed testing-nala-tests labels Jan 9, 2025

cod17828 approved these changes Jan 9, 2025

View reviewed changes

cod17828 self-requested a review January 9, 2025 10:16

cod17828 requested changes Jan 9, 2025

View reviewed changes

sashaCodeTest added 2 commits January 9, 2025 13:27

Implemented requested changes

a11a124

Merge branch 'MWPW-164551-smoke-tests' of github.com:adobecom/dme-par…

e2b9c37

…tners into MWPW-164551-smoke-tests

aem-code-sync bot temporarily deployed to MWPW-164551-smoke-tests January 9, 2025 13:19 Inactive

cod17828 self-requested a review January 9, 2025 13:24

cod17828 approved these changes Jan 9, 2025

View reviewed changes

cod17828 added the run-on-dme label Jan 9, 2025

Implemented requested changes

849eaad

dejanpreradovic approved these changes Jan 10, 2025

View reviewed changes

Ben-Zahler reviewed Jan 10, 2025

View reviewed changes

Requested change for price list locator

9bc685b

cod17828 added run-on-dme and removed run-on-dme labels Jan 13, 2025

Change for price list locator

077e1ec

Ben-Zahler approved these changes Jan 13, 2025

View reviewed changes

sashaCodeTest merged commit c973b78 into stage Jan 13, 2025
11 checks passed

sashaCodeTest deleted the MWPW-164551-smoke-tests branch January 13, 2025 12:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Smoke Tests #176

Smoke Tests #176

sashaCodeTest commented Jan 9, 2025 •

edited

Loading

aem-code-sync bot commented Jan 9, 2025 •

edited

Loading

github-actions bot left a comment

codecov-commenter commented Jan 9, 2025 •

edited

Loading

cod17828 Jan 9, 2025

cod17828 Jan 9, 2025

cod17828 Jan 9, 2025

Ben-Zahler Jan 10, 2025

aem-code-sync bot commented Jan 13, 2025 •

edited

Loading

Smoke Tests #176

Smoke Tests #176

Conversation

sashaCodeTest commented Jan 9, 2025 • edited Loading

aem-code-sync bot commented Jan 9, 2025 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jan 9, 2025 • edited Loading

Codecov Report

cod17828 Jan 9, 2025

Choose a reason for hiding this comment

cod17828 Jan 9, 2025

Choose a reason for hiding this comment

cod17828 Jan 9, 2025

Choose a reason for hiding this comment

Ben-Zahler Jan 10, 2025

Choose a reason for hiding this comment

aem-code-sync bot commented Jan 13, 2025 • edited Loading

sashaCodeTest commented Jan 9, 2025 •

edited

Loading

aem-code-sync bot commented Jan 9, 2025 •

edited

Loading

codecov-commenter commented Jan 9, 2025 •

edited

Loading

aem-code-sync bot commented Jan 13, 2025 •

edited

Loading