removing .renew-banner className and styles, using notification block… #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of aside block updating jest test
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #174 +/- ##
==========================================
- Coverage 81.21% 81.01% -0.21%
==========================================
Files 12 12
Lines 3514 3508 -6
==========================================
- Hits 2854 2842 -12
- Misses 660 666 +6 ☔ View full report in Codecov by Sentry. |
Ben-Zahler
approved these changes
Jan 8, 2025
dejanpreradovic
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
removing .renew-banner className and styles, using notification block instead of aside block, updating jest test
Testing url: https://mwpw-164348-banners--dme-partners--adobecom.hlx.page/na/channelpartners/drafts/tijana/text
set parter_data cookie for yugo-stage-cpp-reseller-us-registered@mailinator.com user
ticket: https://jira.corp.adobe.com/browse/MWPW-164348
WIP
NOTE: Authoring changes needed
Banners should be authored with Notification block instead of Aside
notification (ribbon, center, dark, xs-padding, m-button)