Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-164313 - Pricelists are downloaded as .txt files instead of .csv #167

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

richardhand-fortedigital
Copy link
Collaborator

@richardhand-fortedigital richardhand-fortedigital commented Dec 16, 2024

Copy link

aem-code-sync bot commented Dec 16, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Dec 16, 2024

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.54%. Comparing base (62164e0) to head (48ba4a1).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #167   +/-   ##
=======================================
  Coverage   81.54%   81.54%           
=======================================
  Files          11       11           
  Lines        3484     3484           
=======================================
  Hits         2841     2841           
  Misses        643      643           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- moves filename extraction logic to runtime action
@Ben-Zahler Ben-Zahler merged commit b8165e6 into stage Dec 16, 2024
10 of 11 checks passed
@Ben-Zahler Ben-Zahler deleted the MWPW-164313-pricelist-download-csv branch December 16, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants