MWPW-164053-remove-region #163
Conversation
removing region from query (coming from token and from collection tags)
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
aem-code-sync
bot
temporarily deployed
to
MWPW-164053-remove-region
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #163 +/- ##
==========================================
- Coverage 81.54% 81.31% -0.24%
==========================================
Files 11 12 +1
Lines 3484 3510 +26
==========================================
+ Hits 2841 2854 +13
- Misses 643 656 +13 ☔ View full report in Codecov by Sentry. |
cod17828
requested review from
zagi25,
Ben-Zahler,
SonjaPopovic,
dejanpreradovic and
richardhand-fortedigital
and removed request for
zagi25
|
failing Nala tests are related to requirements changes, we should remove those test for region, or refactor them to check qa-content based on current site |
aem-code-sync
bot
temporarily deployed
to
MWPW-164053-remove-region
edsdme/scripts/utils.js
Outdated
| @@ -341,7 +327,8 @@ function extractTableCollectionTags(el) { | |||
| if (rowTitle === 'collection-tags') { | |||
| const [collectionTagsEl] = colsContent; | |||
| const collectionTags = Array.from(collectionTagsEl.querySelectorAll('li'), (li) => `"${li.textContent.trim().toLowerCase()}"`); | |||
| tableCollectionTags = [...tableCollectionTags, ...collectionTags]; | |||
| const filtered = collectionTags.filter((tag) => !tag.includes('caas:adobe-partners/cpp/region/')); | |||
There was a problem hiding this comment.
@cod17828 sorry if this was not clear, but I don't think we should have any code to handle region tags separately from other tags
aem-code-sync
bot
temporarily deployed
to
MWPW-164053-remove-region
removing region from query (coming from token and from collection tags)
url for testing: https://mwpw-164053-remove-region--dme-partners--adobecom.hlx.live/apac/channelpartners/drafts/tijana/announcements
ticket: MWPW-164053