Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing small issue with restricted announcements #162

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

cod17828
Copy link
Collaborator

@cod17828 cod17828 commented Dec 12, 2024

small changes after yesterday pr, for the restricted by site announcements

url for testing: https://restricted-announcements-fix--dme-partners--adobecom.hlx.page/apac/channelpartners/drafts/tijana/announcements

Copy link

aem-code-sync bot commented Dec 12, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.54%. Comparing base (b931b37) to head (4e60532).

Files with missing lines Patch % Lines
edsdme/blocks/announcements/AnnouncementsCards.js 50.00% 1 Missing ⚠️
edsdme/components/PartnerCards.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #162   +/-   ##
=======================================
  Coverage   81.53%   81.54%           
=======================================
  Files          11       11           
  Lines        3483     3484    +1     
=======================================
+ Hits         2840     2841    +1     
  Misses        643      643           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

aem-code-sync bot commented Dec 12, 2024

@cod17828 cod17828 merged commit cd43d09 into stage Dec 12, 2024
9 of 10 checks passed
@cod17828 cod17828 deleted the restricted-announcements-fix branch December 12, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants