Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-164959 Create SUSI Light Block #939

Open
wants to merge 3 commits into
base: stage
Choose a base branch
from
Open

MWPW-164959 Create SUSI Light Block #939

wants to merge 3 commits into from

Conversation

TsayAdobe
Copy link
Collaborator

  • Use SUSI Light block code from Express
  • DC's IMS client ID doesn't work. Use AdobeExpressWeb for now.

Resolves: MWPW-164959

Test URL:
https://mwpw-164959--dc--adobecom.hlx.page/drafts/tsay/susilight

Copy link

aem-code-sync bot commented Jan 10, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 10, 2025

Page Scores Audits Google
📱 /drafts/tsay/susilight PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/tsay/susilight PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 125 lines in your changes missing coverage. Please review.

Project coverage is 79.22%. Comparing base (b2ed8e4) to head (eb59a97).

Files with missing lines Patch % Lines
acrobat/blocks/susi-light/susi-light.js 0.00% 125 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #939      +/-   ##
==========================================
- Coverage   80.75%   79.22%   -1.54%     
==========================================
  Files          49       50       +1     
  Lines        6502     6627     +125     
==========================================
- Hits         5251     5250       -1     
- Misses       1251     1377     +126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants