Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-164527: Verb widget mobile version #937

Merged
merged 1 commit into from
Jan 13, 2025
Merged

MWPW-164527: Verb widget mobile version #937

merged 1 commit into from
Jan 13, 2025

Conversation

Copy link

aem-code-sync bot commented Jan 9, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 9, 2025

Page Scores Audits Google
📱 /acrobat/online/test/compress-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /acrobat/online/test/compress-pdf PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@TsayAdobe
Copy link
Collaborator

I think we want the widget to fill the whole viewport.
iPhone12

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 80.75%. Comparing base (df00938) to head (cd2050b).

Files with missing lines Patch % Lines
acrobat/blocks/verb-widget/verb-widget.js 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #937      +/-   ##
==========================================
- Coverage   80.89%   80.75%   -0.14%     
==========================================
  Files          49       49              
  Lines        6490     6502      +12     
==========================================
+ Hits         5250     5251       +1     
- Misses       1240     1251      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaquinrivero
Copy link
Collaborator Author

@TsayAdobe it is fixed now

@TsayAdobe TsayAdobe merged commit b2ed8e4 into stage Jan 13, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants