-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DC on hlx5 #917
base: stage
Are you sure you want to change the base?
DC on hlx5 #917
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #917 +/- ##
==========================================
- Coverage 81.31% 81.17% -0.15%
==========================================
Files 49 49
Lines 6429 6501 +72
==========================================
+ Hits 5228 5277 +49
- Misses 1201 1224 +23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'be_nl' found.
'be_nl': 'nl-be', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'be_fr' found.
'be_fr': 'fr-be', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'be_en' found.
'be_en': 'en-be', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'cz' found.
'cz': 'cs-cz', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'cy_en' found.
'cy_en': 'en-cy', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'dk' found.
'dk': 'da-dk', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'de' found.
'de': 'de-de', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ee' found.
'ee': 'et-ee', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'es' found.
'es': 'es-es', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'fr' found.
'fr': 'fr-fr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'gr_en' found.
'gr_en': 'en-gr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'gr_el' found.
'gr_el': 'el-gr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ie' found.
'ie': 'en-ie', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'il_en' found.
'il_en': 'en-il', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'il_he' found.
'il_he': 'he-il', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'it' found.
'it': 'it-it', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'lv' found.
'lv': 'lv-lv', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'lt' found.
'lt': 'lt-lt', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'lu_de' found.
'lu_de': 'de-lu', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'lu_en' found.
'lu_en': 'en-lu', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'lu_fr' found.
'lu_fr': 'fr-lu', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'hu' found.
'hu': 'hu-hu', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'mt' found.
'mt': 'en-mt', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'mena_en' found.
'mena_en': 'en-mena', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'mena_ar' found.
'mena_ar': 'ar-mena', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'nl' found.
'nl': 'nl-nl', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'no' found.
'no': 'nb-no', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'at' found.
'at': 'de-at', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pl' found.
'pl': 'pl-pl', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pt' found.
'pt': 'pt-pt', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ro' found.
'ro': 'ro-ro', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ch_de' found.
'ch_de': 'de-ch', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'si' found.
'si': 'sl-si', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sk' found.
'sk': 'sk-sk', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ch_fr' found.
'ch_fr': 'fr-ch', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'fi' found.
'fi': 'fi-fi', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'se' found.
'se': 'sv-se', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ch_it' found.
'ch_it': 'it-ch', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'tr' found.
'tr': 'tr-tr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'uk' found.
'uk': 'en-uk', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'bg' found.
'bg': 'bg-bg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ru' found.
'ru': 'ru-ru', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ua' found.
'ua': 'uk-ua', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'au' found.
'au': 'en-au', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'hk_en' found.
'hk_en': 'en-hk', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'in' found.
'in': 'en-in', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'in_hi' found.
'in_hi': 'hi-in', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'nz' found.
'nz': 'en-nz', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'hk_zh' found.
'hk_zh': 'zh-hant-hk', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'tw' found.
'tw': 'zh-hant-tw', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'jp' found.
'jp': 'ja-jp', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'kr' found.
'kr': 'ko-kr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ae_en' found.
'ae_en': 'en-ae', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ae_ar' found.
'ae_ar': 'ar-ae', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sa_en' found.
'sa_en': 'en-sa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sa_ar' found.
'sa_ar': 'ar-sa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'th_en' found.
'th_en': 'en-th', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'th_th' found.
'th_th': 'th-th', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sg' found.
'sg': 'en-sg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'cl' found.
'cl': 'es-cl', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'co' found.
'co': 'es-co', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ar' found.
'ar': 'es-ar', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'cr' found.
'cr': 'es-cr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pr' found.
'pr': 'es-pr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ec' found.
'ec': 'es-ec', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pe' found.
'pe': 'es-pe', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'eg_en' found.
'eg_en': 'en-eg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'eg_ar' found.
'eg_ar': 'ar-eg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'gt' found.
'gt': 'es-gt', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'id_en' found.
'id_en': 'en-id', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'id_id' found.
'id_id': 'in-id', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ph_en' found.
'ph_en': 'en-ph', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ph_fil' found.
'ph_fil': 'fil-ph', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'my_en' found.
'my_en': 'en-my', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'my_ms' found.
'my_ms': 'ms-my', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'kw_en' found.
'kw_en': 'en-kw', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'kw_ar' found.
'kw_ar': 'ar-kw', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ng' found.
'ng': 'en-ng', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'qa_en' found.
'qa_en': 'en-qa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'qa_ar' found.
'qa_ar': 'ar-qa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'vn_en' found.
'vn_en': 'en-vn', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'vn_vi' found.
'vn_vi': 'vi-vn' |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
'vn_vi': 'vi-vn' | |
}; |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'createpdf' found.
'createpdf': 'createpdf', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sendforsignature' found.
'sendforsignature': 'sendforsignature', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'fillsign' found.
'fillsign': 'fillsign', |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'url' is never reassigned. Use 'const' instead.
let url = new URL(window.location.href); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
let url = new URL(window.location.href); |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'langFromPath' is never reassigned. Use 'const' instead.
let langFromPath = url.pathname.split('/')[1]; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'DC_GENERATE_CACHE_VERSION_FALLBACK' is assigned a value but never used.
const DC_GENERATE_CACHE_VERSION_FALLBACK = '1.172.1'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'DC_GENERATE_CACHE_VERSION' is assigned a value but never used.
DC_GENERATE_CACHE_VERSION = STG_DC_GENERATE_CACHE_VERSION; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
const dynamicHead = VERB === 'jpg-to-pdf' ? HEADING : WORD_HEADING; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
const dynamicCopy = VERB === 'jpg-to-pdf' ? COPY : WORD_COPY; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
//Create Fake Widget |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
//Create Fake Widget |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
createTag.then((tag) => { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const wrapper = tag('div', {id: 'CID', class: `fsw widget-wrapper wapper-${VERB}` }); |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
const wrapper = tag('div', {id: 'CID', class: `fsw widget-wrapper wapper-${VERB}` }); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const heading = tag('h1', { class: 'widget-heading' }, dynamicHead); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const center = tag('div', { class: 'widget-center' }); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const copy = tag('p', { class: 'widget-copy' }, dynamicCopy); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const legal = tag('p', { class: 'widget-legal' }, LEGAL); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const button = tag('p', { class: 'widget-button' }, BTN); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
wrapper.append(heading); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
wrapper.append(center) |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 181 to 182 in 7e157f2
wrapper.append(center) | |
center.append(copy); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
center.append(copy); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
center.append(button); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
wrapper.append(legal); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
element.append(wrapper); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const dcWidgetScript = tag('script', { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
id: 'adobe_dc_sdk_launcher', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
src: WIDGET_ENV, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-dropzone_id': 'CID', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-locale': pageLang, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-server_env': ENV, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-verb': VERB, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-load_typekit': 'false', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-load_imslib': 'false', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-enable_unload_prompt': 'true', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// element.prepend(dcWidgetScript); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
document.addEventListener('milo:deferred', ()=> { |
🚫 [eslint] <arrow-spacing> reported by reviewdog 🐶
Missing space before =>.
document.addEventListener('milo:deferred', ()=> { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
wrapper.classList.add('widget-loaded'); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
element.prepend(dcWidgetScript); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 203 to 204 in 7e157f2
}) | |
// setTimeout(() => { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// setTimeout(() => { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// wrapper.classList.add('widget-loaded'); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// console.log('load widget'); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// element.prepend(dcWidgetScript); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// }, 5000) |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
// Generate cache url |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
const GENERATE_CACHE_URL_DIV = widget.querySelectorAll('div')[4]; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
if (GENERATE_CACHE_URL_DIV) { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
// GENERATE_CACHE_URL_DIV.id = 'GENERATE_CACHE_URL'; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
DC_GENERATE_CACHE_URL = GENERATE_CACHE_URL_DIV.textContent.trim(); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'DC_GENERATE_CACHE_URL' is assigned a value but never used.
DC_GENERATE_CACHE_URL = GENERATE_CACHE_URL_DIV.textContent.trim(); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
GENERATE_CACHE_URL_DIV.remove(); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
🚫 [eslint] <import/no-unresolved> reported by reviewdog 🐶
Unable to resolve path to module '../../scripts/legacyBrowser.js'.
const { redirectLegacyBrowsers } = await import('../../scripts/legacyBrowser.js'); |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 253 to 254 in 7e157f2
}) | |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'evt' is never reassigned. Use 'const' instead.
evt = new CustomEvent('dc.imslib.ready', { detail: { instance: window.adobeIMS }}); |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
evt = new CustomEvent('dc.imslib.ready', { detail: { instance: window.adobeIMS }}); |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 263 to 264 in 7e157f2
}) | |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
//import init from '../../../acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb'; |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
'utf8' | |
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.performance.mark = jest.fn(); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
jest.clearAllMocks(); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'fetchUrl' is assigned a value but never used.
let fetchUrl = ''; |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
fetch is not supported in op_mini all
window.fetch = jest.fn((url) => { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.fetch = jest.fn((url) => { |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
return Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://www.adobe.com'); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(launcher.getAttribute('src')).toMatch(/^https:\/\/acrobat.adobe.com\//); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
fetch is not supported in op_mini all
window.fetch = jest.fn((url) => { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.fetch = jest.fn((url) => { |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
return Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL(`https://${hostname}`); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(launcher.getAttribute('src')).toMatch(/^https:\/\/stage.acrobat.adobe.com\//); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
expect(launcher.getAttribute('src')).toMatch(/^https:\/\/stage.acrobat.adobe.com\//); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
fetch is not supported in op_mini all
window.fetch = jest.fn(() => |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.fetch = jest.fn(() => |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve({ |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve({ |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
Promise.resolve({ |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
}) | |
); |
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://www.adobe.com'); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(document.querySelector('#CID').children).toHaveLength(3); |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve({ |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
}) | |
); |
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
window.adobeIMS = { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
isSignedInUser: jest.fn(() => true) |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 100 to 101 in 7e157f2
isSignedInUser: jest.fn(() => true) | |
}; |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL(`https://${hostname}`); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(window.location).toMatch(/^https:\/\/www.adobe.com\/go\/acrobat-/); |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve({ |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 120 to 121 in 7e157f2
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 122 to 123 in 7e157f2
}) | |
); |
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
window.adobeIMS = { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
isSignedInUser: jest.fn(() => true) |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 125 to 126 in 7e157f2
isSignedInUser: jest.fn(() => true) | |
}; |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL(`https://${hostname}`); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
//expect(window.location).toMatch(/https:\/\/www.adobe.com\/go\/testredirect/); |
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension "js" for "../../../acrobat/scripts/contentSecurityPolicy/csp"
import ContentSecurityPolicy from '../../../acrobat/scripts/contentSecurityPolicy/csp'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'hostnameGetter' is defined but never used.
let hostnameGetter; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'url' is defined but never used.
let url; |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://www.adobe.com/acrobat/online/test'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://localhost:2000/acrobat/online/test'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
Line 4 in 7e157f2
//import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 14 to 16 in 7e157f2
window.location = new URL( | |
'https://www.adobe.com' | |
); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
Lines 15 to 16 in 7e157f2
'https://www.adobe.com' | |
); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 16 in 7e157f2
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'setLibs' is not defined.
Line 17 in 7e157f2
const libs = setLibs('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 18 in 7e157f2
expect(libs).toBe('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 19 in 7e157f2
expect(getLibs()).toBe('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'getLibs' is not defined.
Line 19 in 7e157f2
expect(getLibs()).toBe('/libs'); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 24 to 26 in 7e157f2
window.location = new URL( | |
'https://www.stage.adobe.com' | |
); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
Lines 25 to 26 in 7e157f2
'https://www.stage.adobe.com' | |
); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 26 in 7e157f2
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'setLibs' is not defined.
Line 27 in 7e157f2
const libs = setLibs('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 28 in 7e157f2
expect(libs).toBe('https://www.adobe.com/libs'); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 29 in 7e157f2
}); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 33 to 35 in 7e157f2
window.location = new URL( | |
'https://www.stage.adobe.com?milolibs=local' | |
); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
Lines 34 to 35 in 7e157f2
'https://www.stage.adobe.com?milolibs=local' | |
); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 35 in 7e157f2
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'setLibs' is not defined.
Line 36 in 7e157f2
const libs = setLibs('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 37 in 7e157f2
expect(libs).toBe('http://localhost:6456/libs'); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 42 to 44 in 7e157f2
window.location = new URL( | |
'https://www.stage.adobe.com?milolibs=main--milo--tsayadobe' | |
); |
🚫 [eslint] <import/order> reported by reviewdog 🐶../../acrobat/scripts/utils
import should occur after import of @esm-bundle/chai
Line 1 in 7e157f2
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'getLibs' is defined but never used.
Line 1 in 7e157f2
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension "js" for "../../acrobat/scripts/utils"
Line 1 in 7e157f2
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'sinon' is defined but never used.
Line 2 in 7e157f2
import * as sinon from 'sinon'; |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(!eventWrappers.length){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/eventWrapper.js
Lines 16 to 18 in 7e157f2
if(!eventWrappers.length){ | |
return; | |
} |
🚫 [eslint] <no-confusing-arrow> reported by reviewdog 🐶
Arrow function used ambiguously with a conditional expression.
const eventWrapper = Array.from(eventWrappers).filter((wrapper) => wrapper.querySelector(':scope > div').getAttribute('data-event-name') === 'onload' ? wrapper : wrapper.remove()); |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(!eventWrapper[0]){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/eventWrapper.js
Lines 22 to 24 in 7e157f2
if(!eventWrapper[0]){ | |
return; | |
} |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(dataPath && dataPath.includes('caas')){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/eventWrapper.js
Lines 29 to 31 in 7e157f2
if(dataPath && dataPath.includes('caas')){ | |
fragmentTypes.splice(3, 0, 'caas'); | |
} |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
const urlObject = new URL(url); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/tools/importScript/rules/eventWrapper.js
Lines 53 to 54 in 7e157f2
document | |
); |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/tools/importScript/rules/eventWrapper.js
Lines 62 to 63 in 7e157f2
} | |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'WebImporter' is not defined.
dc/tools/importScript/rules/metaData.js
Line 30 in 7e157f2
const block = WebImporter.Blocks.getMetadataBlock(document, meta); |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(!fragments.length) { |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
dc/tools/importScript/rules/verbFooter.js
Line 15 in 7e157f2
if(dataPath1 && dataPath1.includes('shell')){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/verbFooter.js
Lines 15 to 21 in 7e157f2
if(dataPath1 && dataPath1.includes('shell')){ | |
fragment.before(document.createElement('hr')); | |
fragment.after(document.createElement('hr')); | |
fragment.replaceWith(verbFragmentLink); | |
return; | |
} |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
dc/tools/importScript/rules/verbFooter.js
Line 24 in 7e157f2
if(dataPath2 && dataPath2.includes('verb-footer')){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/verbFooter.js
Lines 24 to 30 in 7e157f2
if(dataPath2 && dataPath2.includes('verb-footer')){ | |
fragment.before(document.createElement('hr')); | |
fragment.after(document.createElement('hr')); | |
fragment.replaceWith(verbFragmentLink); | |
return; | |
} |
🚫 [eslint] <no-useless-return> reported by reviewdog 🐶
Unnecessary return statement.
dc/tools/importScript/rules/verbFooter.js
Line 29 in 7e157f2
return; |
🚫 [eslint] <padded-blocks> reported by reviewdog 🐶
Block must not be padded by blank lines.
dc/tools/importScript/rules/verbFooter.js
Lines 31 to 33 in 7e157f2
}); | |
} |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/tools/importScript/rules/verbFooter.js
Lines 33 to 34 in 7e157f2
} | |
if (window.location.hostname === 'stage--dc--adobecom.aem.page' | ||
|| window.location.hostname === 'main--dc--adobecom.aem.page' | ||
|| window.location.hostname === 'stage--dc--adobecom.aem.live' | ||
|| window.location.hostname === 'main--dc--adobecom.aem.live' | ||
|| window.location.hostname === 'www.stage.adobe.com') { | ||
WIDGET_ENV = `https://stage.acrobat.adobe.com/dc-hosted/${STG_DC_WIDGET_VERSION}/dc-app-launcher.js`; | ||
DC_DOMAIN = 'https://stage.acrobat.adobe.com'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'DC_DOMAIN' is assigned a value but never used.
@@ -227,7 +227,7 @@ | |||
// Redirect | |||
const fallBack = 'https://www.adobe.com/go/acrobat-overview'; | |||
const redDir = () => { | |||
if (window.location.hostname != 'main--dc--adobecom.hlx.live' | |||
if (window.location.hostname != 'main--dc--adobecom.aem.live' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -227,7 +227,7 @@ | |||
// Redirect | |||
const fallBack = 'https://www.adobe.com/go/acrobat-overview'; | |||
const redDir = () => { | |||
if (window.location.hostname != 'main--dc--adobecom.hlx.live' | |||
if (window.location.hostname != 'main--dc--adobecom.aem.live' | |||
&& window.location.hostname != 'www.adobe.com' ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -227,7 +227,7 @@ | |||
// Redirect | |||
const fallBack = 'https://www.adobe.com/go/acrobat-overview'; | |||
const redDir = () => { | |||
if (window.location.hostname != 'main--dc--adobecom.hlx.live' | |||
if (window.location.hostname != 'main--dc--adobecom.aem.live' | |||
&& window.location.hostname != 'www.adobe.com' ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <space-in-parens> reported by reviewdog 🐶
There should be no space before this paren.
&& window.location.hostname != 'www.adobe.com' ) { | |
&& window.location.hostname != 'www.adobe.com') { |
@@ -227,7 +227,7 @@ | |||
// Redirect | |||
const fallBack = 'https://www.adobe.com/go/acrobat-overview'; | |||
const redDir = () => { | |||
if (window.location.hostname != 'main--dc--adobecom.hlx.live' | |||
if (window.location.hostname != 'main--dc--adobecom.aem.live' | |||
&& window.location.hostname != 'www.adobe.com' ) { | |||
window.location = `https://www.adobe.com/go/acrobat-${verbRedirMap[VERB] || VERB.split('-').join('')}-${ENV}`|| REDIRECT_URL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <space-infix-ops> reported by reviewdog 🐶
Operator '||' must be spaced.
window.location = `https://www.adobe.com/go/acrobat-${verbRedirMap[VERB] || VERB.split('-').join('')}-${ENV}`|| REDIRECT_URL; | |
window.location = `https://www.adobe.com/go/acrobat-${verbRedirMap[VERB] || VERB.split('-').join('')}-${ENV}` || REDIRECT_URL; |
} | ||
|
||
return `https://main--dc--adobecom.hlx.page/dc-shared/fragments/personalization-summary-frags/${page}/summary-frag-${type}` | ||
return `https://main--dc--adobecom.aem.page/dc-shared/fragments/personalization-summary-frags/${page}/summary-frag-${type}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
return `https://main--dc--adobecom.aem.page/dc-shared/fragments/personalization-summary-frags/${page}/summary-frag-${type}` | |
return `https://main--dc--adobecom.aem.page/dc-shared/fragments/personalization-summary-frags/${page}/summary-frag-${type}`; |
} | ||
|
||
return `https://main--dc--adobecom.hlx.page/dc-shared/fragments/personalization-summary-frags/${page}/summary-frag-${type}` | ||
return `https://main--dc--adobecom.aem.page/dc-shared/fragments/personalization-summary-frags/${page}/summary-frag-${type}` | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta.Chromeext = 'https://main--dc--adobecom.hlx.live/dc-shared/fragments/shared-fragments/browser-extension/browser-extension-chrome'; | ||
meta.Edgeext = 'https://main--dc--adobecom.hlx.live/dc-shared/fragments/shared-fragments/browser-extension/browser-extension-edge' | ||
meta.Chromeext = 'https://main--dc--adobecom.aem.live/dc-shared/fragments/shared-fragments/browser-extension/browser-extension-chrome'; | ||
meta.Edgeext = 'https://main--dc--adobecom.aem.live/dc-shared/fragments/shared-fragments/browser-extension/browser-extension-edge' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
meta.Edgeext = 'https://main--dc--adobecom.aem.live/dc-shared/fragments/shared-fragments/browser-extension/browser-extension-edge' | |
meta.Edgeext = 'https://main--dc--adobecom.aem.live/dc-shared/fragments/shared-fragments/browser-extension/browser-extension-edge'; |
|
||
const FRAGMENTLINK = 'https://main--dc--adobecom.hlx.page/dc-shared/fragments/shared-fragments/frictionless/verb-footer/verb-footer-shell' | ||
const FRAGMENTLINK = 'https://main--dc--adobecom.aem.page/dc-shared/fragments/shared-fragments/frictionless/verb-footer/verb-footer-shell' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <no-multiple-empty-lines> reported by reviewdog 🐶
Too many blank lines at the beginning of file. Max of 0 allowed.
const FRAGMENTLINK = 'https://main--dc--adobecom.hlx.page/dc-shared/fragments/shared-fragments/frictionless/verb-footer/verb-footer-shell' | |
const FRAGMENTLINK = 'https://main--dc--adobecom.aem.page/dc-shared/fragments/shared-fragments/frictionless/verb-footer/verb-footer-shell' | |
const FRAGMENTLINK = 'https://main--dc--adobecom.aem.page/dc-shared/fragments/shared-fragments/frictionless/verb-footer/verb-footer-shell' |
@@ -1,5 +1,5 @@ | |||
|
|||
const FRAGMENTLINK = 'https://main--dc--adobecom.hlx.page/dc-shared/fragments/shared-fragments/frictionless/verb-footer/verb-footer-shell' | |||
const FRAGMENTLINK = 'https://main--dc--adobecom.aem.page/dc-shared/fragments/shared-fragments/frictionless/verb-footer/verb-footer-shell' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
const FRAGMENTLINK = 'https://main--dc--adobecom.aem.page/dc-shared/fragments/shared-fragments/frictionless/verb-footer/verb-footer-shell' | |
const FRAGMENTLINK = 'https://main--dc--adobecom.aem.page/dc-shared/fragments/shared-fragments/frictionless/verb-footer/verb-footer-shell'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
import {createTag} from "../../scripts/miloUtils.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
import {createTag} from "../../scripts/miloUtils.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'br' found.
'br': 'pt-br', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ca' found.
'ca': 'en-ca', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ca_fr' found.
'ca_fr': 'fr-ca', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'mx' found.
'mx': 'es-mx', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'la' found.
'la': 'es-la', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'africa' found.
'africa': 'en-africa', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'za' found.
'za': 'en-za', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'gr_en' found.
'gr_en': 'en-gr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'gr_el' found.
'gr_el': 'el-gr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ie' found.
'ie': 'en-ie', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'il_en' found.
'il_en': 'en-il', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'il_he' found.
'il_he': 'he-il', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'it' found.
'it': 'it-it', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'lv' found.
'lv': 'lv-lv', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'lt' found.
'lt': 'lt-lt', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'lu_de' found.
'lu_de': 'de-lu', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'lu_en' found.
'lu_en': 'en-lu', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'lu_fr' found.
'lu_fr': 'fr-lu', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'hu' found.
'hu': 'hu-hu', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'mt' found.
'mt': 'en-mt', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'mena_en' found.
'mena_en': 'en-mena', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'mena_ar' found.
'mena_ar': 'ar-mena', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'nl' found.
'nl': 'nl-nl', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'no' found.
'no': 'nb-no', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'at' found.
'at': 'de-at', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pl' found.
'pl': 'pl-pl', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pt' found.
'pt': 'pt-pt', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ro' found.
'ro': 'ro-ro', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ch_de' found.
'ch_de': 'de-ch', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'si' found.
'si': 'sl-si', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sk' found.
'sk': 'sk-sk', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ch_fr' found.
'ch_fr': 'fr-ch', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'fi' found.
'fi': 'fi-fi', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'se' found.
'se': 'sv-se', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ch_it' found.
'ch_it': 'it-ch', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'tr' found.
'tr': 'tr-tr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'uk' found.
'uk': 'en-uk', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'bg' found.
'bg': 'bg-bg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ru' found.
'ru': 'ru-ru', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ua' found.
'ua': 'uk-ua', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'au' found.
'au': 'en-au', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'hk_en' found.
'hk_en': 'en-hk', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'in' found.
'in': 'en-in', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'in_hi' found.
'in_hi': 'hi-in', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'nz' found.
'nz': 'en-nz', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'hk_zh' found.
'hk_zh': 'zh-hant-hk', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'tw' found.
'tw': 'zh-hant-tw', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'jp' found.
'jp': 'ja-jp', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'kr' found.
'kr': 'ko-kr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ae_en' found.
'ae_en': 'en-ae', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ae_ar' found.
'ae_ar': 'ar-ae', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sa_en' found.
'sa_en': 'en-sa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sa_ar' found.
'sa_ar': 'ar-sa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'th_en' found.
'th_en': 'en-th', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'th_th' found.
'th_th': 'th-th', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sg' found.
'sg': 'en-sg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'cl' found.
'cl': 'es-cl', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'co' found.
'co': 'es-co', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ar' found.
'ar': 'es-ar', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'cr' found.
'cr': 'es-cr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pr' found.
'pr': 'es-pr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ec' found.
'ec': 'es-ec', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pe' found.
'pe': 'es-pe', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'eg_en' found.
'eg_en': 'en-eg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'eg_ar' found.
'eg_ar': 'ar-eg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'gt' found.
'gt': 'es-gt', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'id_en' found.
'id_en': 'en-id', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'id_id' found.
'id_id': 'in-id', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ph_en' found.
'ph_en': 'en-ph', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ph_fil' found.
'ph_fil': 'fil-ph', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'my_en' found.
'my_en': 'en-my', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'my_ms' found.
'my_ms': 'ms-my', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'kw_en' found.
'kw_en': 'en-kw', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'kw_ar' found.
'kw_ar': 'ar-kw', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ng' found.
'ng': 'en-ng', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'qa_en' found.
'qa_en': 'en-qa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'qa_ar' found.
'qa_ar': 'ar-qa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'vn_en' found.
'vn_en': 'en-vn', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'vn_vi' found.
'vn_vi': 'vi-vn' |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
'vn_vi': 'vi-vn' | |
}; |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'createpdf' found.
'createpdf': 'createpdf', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sendforsignature' found.
'sendforsignature': 'sendforsignature', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'fillsign' found.
'fillsign': 'fillsign', |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'url' is never reassigned. Use 'const' instead.
let url = new URL(window.location.href); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
let url = new URL(window.location.href); |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'langFromPath' is never reassigned. Use 'const' instead.
let langFromPath = url.pathname.split('/')[1]; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'DC_GENERATE_CACHE_VERSION_FALLBACK' is assigned a value but never used.
const DC_GENERATE_CACHE_VERSION_FALLBACK = '1.172.1'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'DC_GENERATE_CACHE_VERSION' is assigned a value but never used.
DC_GENERATE_CACHE_VERSION = STG_DC_GENERATE_CACHE_VERSION; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
const dynamicHead = VERB === 'jpg-to-pdf' ? HEADING : WORD_HEADING; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
const dynamicCopy = VERB === 'jpg-to-pdf' ? COPY : WORD_COPY; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
//Create Fake Widget |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
//Create Fake Widget |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
createTag.then((tag) => { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const wrapper = tag('div', {id: 'CID', class: `fsw widget-wrapper wapper-${VERB}` }); |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
const wrapper = tag('div', {id: 'CID', class: `fsw widget-wrapper wapper-${VERB}` }); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const heading = tag('h1', { class: 'widget-heading' }, dynamicHead); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const center = tag('div', { class: 'widget-center' }); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const copy = tag('p', { class: 'widget-copy' }, dynamicCopy); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const legal = tag('p', { class: 'widget-legal' }, LEGAL); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const button = tag('p', { class: 'widget-button' }, BTN); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
wrapper.append(heading); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
wrapper.append(center) |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 181 to 182 in 7e157f2
wrapper.append(center) | |
center.append(copy); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
center.append(copy); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
center.append(button); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
wrapper.append(legal); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
element.append(wrapper); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const dcWidgetScript = tag('script', { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
id: 'adobe_dc_sdk_launcher', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
src: WIDGET_ENV, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-dropzone_id': 'CID', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-locale': pageLang, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-server_env': ENV, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-verb': VERB, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-load_typekit': 'false', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-load_imslib': 'false', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-enable_unload_prompt': 'true', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// element.prepend(dcWidgetScript); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
document.addEventListener('milo:deferred', ()=> { |
🚫 [eslint] <arrow-spacing> reported by reviewdog 🐶
Missing space before =>.
document.addEventListener('milo:deferred', ()=> { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
wrapper.classList.add('widget-loaded'); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
element.prepend(dcWidgetScript); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 203 to 204 in 7e157f2
}) | |
// setTimeout(() => { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// setTimeout(() => { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// wrapper.classList.add('widget-loaded'); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// console.log('load widget'); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// element.prepend(dcWidgetScript); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// }, 5000) |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
// Generate cache url |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
const GENERATE_CACHE_URL_DIV = widget.querySelectorAll('div')[4]; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
if (GENERATE_CACHE_URL_DIV) { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
// GENERATE_CACHE_URL_DIV.id = 'GENERATE_CACHE_URL'; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
DC_GENERATE_CACHE_URL = GENERATE_CACHE_URL_DIV.textContent.trim(); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'DC_GENERATE_CACHE_URL' is assigned a value but never used.
DC_GENERATE_CACHE_URL = GENERATE_CACHE_URL_DIV.textContent.trim(); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
GENERATE_CACHE_URL_DIV.remove(); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
🚫 [eslint] <import/no-unresolved> reported by reviewdog 🐶
Unable to resolve path to module '../../scripts/legacyBrowser.js'.
const { redirectLegacyBrowsers } = await import('../../scripts/legacyBrowser.js'); |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 253 to 254 in 7e157f2
}) | |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'evt' is never reassigned. Use 'const' instead.
evt = new CustomEvent('dc.imslib.ready', { detail: { instance: window.adobeIMS }}); |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
evt = new CustomEvent('dc.imslib.ready', { detail: { instance: window.adobeIMS }}); |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 263 to 264 in 7e157f2
}) | |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
//import init from '../../../acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb'; |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
'utf8' | |
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.performance.mark = jest.fn(); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
jest.clearAllMocks(); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'fetchUrl' is assigned a value but never used.
let fetchUrl = ''; |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
fetch is not supported in op_mini all
window.fetch = jest.fn((url) => { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.fetch = jest.fn((url) => { |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
return Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://www.adobe.com'); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(launcher.getAttribute('src')).toMatch(/^https:\/\/acrobat.adobe.com\//); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
fetch is not supported in op_mini all
window.fetch = jest.fn((url) => { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.fetch = jest.fn((url) => { |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
return Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL(`https://${hostname}`); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(launcher.getAttribute('src')).toMatch(/^https:\/\/stage.acrobat.adobe.com\//); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
expect(launcher.getAttribute('src')).toMatch(/^https:\/\/stage.acrobat.adobe.com\//); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
fetch is not supported in op_mini all
window.fetch = jest.fn(() => |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.fetch = jest.fn(() => |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve({ |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve({ |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
Promise.resolve({ |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
}) | |
); |
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://www.adobe.com'); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(document.querySelector('#CID').children).toHaveLength(3); |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve({ |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
}) | |
); |
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
window.adobeIMS = { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
isSignedInUser: jest.fn(() => true) |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 100 to 101 in 7e157f2
isSignedInUser: jest.fn(() => true) | |
}; |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL(`https://${hostname}`); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(window.location).toMatch(/^https:\/\/www.adobe.com\/go\/acrobat-/); |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve({ |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 120 to 121 in 7e157f2
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 122 to 123 in 7e157f2
}) | |
); |
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
window.adobeIMS = { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
isSignedInUser: jest.fn(() => true) |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 125 to 126 in 7e157f2
isSignedInUser: jest.fn(() => true) | |
}; |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL(`https://${hostname}`); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
//expect(window.location).toMatch(/https:\/\/www.adobe.com\/go\/testredirect/); |
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension "js" for "../../../acrobat/scripts/contentSecurityPolicy/csp"
import ContentSecurityPolicy from '../../../acrobat/scripts/contentSecurityPolicy/csp'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'hostnameGetter' is defined but never used.
let hostnameGetter; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'url' is defined but never used.
let url; |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://www.adobe.com/acrobat/online/test'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://localhost:2000/acrobat/online/test'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
Line 4 in 7e157f2
//import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 14 to 16 in 7e157f2
window.location = new URL( | |
'https://www.adobe.com' | |
); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
Lines 15 to 16 in 7e157f2
'https://www.adobe.com' | |
); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 16 in 7e157f2
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'setLibs' is not defined.
Line 17 in 7e157f2
const libs = setLibs('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 18 in 7e157f2
expect(libs).toBe('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 19 in 7e157f2
expect(getLibs()).toBe('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'getLibs' is not defined.
Line 19 in 7e157f2
expect(getLibs()).toBe('/libs'); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 24 to 26 in 7e157f2
window.location = new URL( | |
'https://www.stage.adobe.com' | |
); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
Lines 25 to 26 in 7e157f2
'https://www.stage.adobe.com' | |
); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 26 in 7e157f2
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'setLibs' is not defined.
Line 27 in 7e157f2
const libs = setLibs('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 28 in 7e157f2
expect(libs).toBe('https://www.adobe.com/libs'); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 29 in 7e157f2
}); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 33 to 35 in 7e157f2
window.location = new URL( | |
'https://www.stage.adobe.com?milolibs=local' | |
); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
Lines 34 to 35 in 7e157f2
'https://www.stage.adobe.com?milolibs=local' | |
); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 35 in 7e157f2
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'setLibs' is not defined.
Line 36 in 7e157f2
const libs = setLibs('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 37 in 7e157f2
expect(libs).toBe('http://localhost:6456/libs'); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 42 to 44 in 7e157f2
window.location = new URL( | |
'https://www.stage.adobe.com?milolibs=main--milo--tsayadobe' | |
); |
🚫 [eslint] <import/order> reported by reviewdog 🐶../../acrobat/scripts/utils
import should occur after import of @esm-bundle/chai
Line 1 in 7e157f2
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'getLibs' is defined but never used.
Line 1 in 7e157f2
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension "js" for "../../acrobat/scripts/utils"
Line 1 in 7e157f2
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'sinon' is defined but never used.
Line 2 in 7e157f2
import * as sinon from 'sinon'; |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(!eventWrappers.length){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/eventWrapper.js
Lines 16 to 18 in 7e157f2
if(!eventWrappers.length){ | |
return; | |
} |
🚫 [eslint] <no-confusing-arrow> reported by reviewdog 🐶
Arrow function used ambiguously with a conditional expression.
const eventWrapper = Array.from(eventWrappers).filter((wrapper) => wrapper.querySelector(':scope > div').getAttribute('data-event-name') === 'onload' ? wrapper : wrapper.remove()); |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(!eventWrapper[0]){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/eventWrapper.js
Lines 22 to 24 in 7e157f2
if(!eventWrapper[0]){ | |
return; | |
} |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(dataPath && dataPath.includes('caas')){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/eventWrapper.js
Lines 29 to 31 in 7e157f2
if(dataPath && dataPath.includes('caas')){ | |
fragmentTypes.splice(3, 0, 'caas'); | |
} |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
const urlObject = new URL(url); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/tools/importScript/rules/eventWrapper.js
Lines 53 to 54 in 7e157f2
document | |
); |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/tools/importScript/rules/eventWrapper.js
Lines 62 to 63 in 7e157f2
} | |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'WebImporter' is not defined.
dc/tools/importScript/rules/metaData.js
Line 30 in 7e157f2
const block = WebImporter.Blocks.getMetadataBlock(document, meta); |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(!fragments.length) { |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
dc/tools/importScript/rules/verbFooter.js
Line 15 in 7e157f2
if(dataPath1 && dataPath1.includes('shell')){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/verbFooter.js
Lines 15 to 21 in 7e157f2
if(dataPath1 && dataPath1.includes('shell')){ | |
fragment.before(document.createElement('hr')); | |
fragment.after(document.createElement('hr')); | |
fragment.replaceWith(verbFragmentLink); | |
return; | |
} |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
dc/tools/importScript/rules/verbFooter.js
Line 24 in 7e157f2
if(dataPath2 && dataPath2.includes('verb-footer')){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/verbFooter.js
Lines 24 to 30 in 7e157f2
if(dataPath2 && dataPath2.includes('verb-footer')){ | |
fragment.before(document.createElement('hr')); | |
fragment.after(document.createElement('hr')); | |
fragment.replaceWith(verbFragmentLink); | |
return; | |
} |
🚫 [eslint] <no-useless-return> reported by reviewdog 🐶
Unnecessary return statement.
dc/tools/importScript/rules/verbFooter.js
Line 29 in 7e157f2
return; |
🚫 [eslint] <padded-blocks> reported by reviewdog 🐶
Block must not be padded by blank lines.
dc/tools/importScript/rules/verbFooter.js
Lines 31 to 33 in 7e157f2
}); | |
} |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/tools/importScript/rules/verbFooter.js
Lines 33 to 34 in 7e157f2
} | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'be_nl' found.
'be_nl': 'nl-be', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'be_fr' found.
'be_fr': 'fr-be', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'be_en' found.
'be_en': 'en-be', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'cz' found.
'cz': 'cs-cz', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'cy_en' found.
'cy_en': 'en-cy', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'dk' found.
'dk': 'da-dk', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'de' found.
'de': 'de-de', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ee' found.
'ee': 'et-ee', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'es' found.
'es': 'es-es', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'fr' found.
'fr': 'fr-fr', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'lu_fr' found.
'lu_fr': 'fr-lu', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'hu' found.
'hu': 'hu-hu', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'mt' found.
'mt': 'en-mt', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'mena_en' found.
'mena_en': 'en-mena', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'mena_ar' found.
'mena_ar': 'ar-mena', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'nl' found.
'nl': 'nl-nl', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'no' found.
'no': 'nb-no', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'at' found.
'at': 'de-at', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pl' found.
'pl': 'pl-pl', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pt' found.
'pt': 'pt-pt', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ro' found.
'ro': 'ro-ro', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ch_de' found.
'ch_de': 'de-ch', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'si' found.
'si': 'sl-si', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sk' found.
'sk': 'sk-sk', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ch_fr' found.
'ch_fr': 'fr-ch', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'fi' found.
'fi': 'fi-fi', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'se' found.
'se': 'sv-se', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ch_it' found.
'ch_it': 'it-ch', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'tr' found.
'tr': 'tr-tr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'uk' found.
'uk': 'en-uk', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'bg' found.
'bg': 'bg-bg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ru' found.
'ru': 'ru-ru', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ua' found.
'ua': 'uk-ua', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'au' found.
'au': 'en-au', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'hk_en' found.
'hk_en': 'en-hk', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'in' found.
'in': 'en-in', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'in_hi' found.
'in_hi': 'hi-in', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'nz' found.
'nz': 'en-nz', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'hk_zh' found.
'hk_zh': 'zh-hant-hk', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'tw' found.
'tw': 'zh-hant-tw', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'jp' found.
'jp': 'ja-jp', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'kr' found.
'kr': 'ko-kr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ae_en' found.
'ae_en': 'en-ae', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ae_ar' found.
'ae_ar': 'ar-ae', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sa_en' found.
'sa_en': 'en-sa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sa_ar' found.
'sa_ar': 'ar-sa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'th_en' found.
'th_en': 'en-th', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'th_th' found.
'th_th': 'th-th', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sg' found.
'sg': 'en-sg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'cl' found.
'cl': 'es-cl', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'co' found.
'co': 'es-co', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ar' found.
'ar': 'es-ar', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'cr' found.
'cr': 'es-cr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pr' found.
'pr': 'es-pr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ec' found.
'ec': 'es-ec', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pe' found.
'pe': 'es-pe', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'eg_en' found.
'eg_en': 'en-eg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'eg_ar' found.
'eg_ar': 'ar-eg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'gt' found.
'gt': 'es-gt', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'id_en' found.
'id_en': 'en-id', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'id_id' found.
'id_id': 'in-id', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ph_en' found.
'ph_en': 'en-ph', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ph_fil' found.
'ph_fil': 'fil-ph', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'my_en' found.
'my_en': 'en-my', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'my_ms' found.
'my_ms': 'ms-my', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'kw_en' found.
'kw_en': 'en-kw', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'kw_ar' found.
'kw_ar': 'ar-kw', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ng' found.
'ng': 'en-ng', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'qa_en' found.
'qa_en': 'en-qa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'qa_ar' found.
'qa_ar': 'ar-qa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'vn_en' found.
'vn_en': 'en-vn', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'vn_vi' found.
'vn_vi': 'vi-vn' |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
'vn_vi': 'vi-vn' | |
}; |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'createpdf' found.
'createpdf': 'createpdf', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sendforsignature' found.
'sendforsignature': 'sendforsignature', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'fillsign' found.
'fillsign': 'fillsign', |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'url' is never reassigned. Use 'const' instead.
let url = new URL(window.location.href); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
let url = new URL(window.location.href); |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'langFromPath' is never reassigned. Use 'const' instead.
let langFromPath = url.pathname.split('/')[1]; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'DC_GENERATE_CACHE_VERSION_FALLBACK' is assigned a value but never used.
const DC_GENERATE_CACHE_VERSION_FALLBACK = '1.172.1'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'DC_GENERATE_CACHE_VERSION' is assigned a value but never used.
DC_GENERATE_CACHE_VERSION = STG_DC_GENERATE_CACHE_VERSION; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
const dynamicHead = VERB === 'jpg-to-pdf' ? HEADING : WORD_HEADING; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
const dynamicCopy = VERB === 'jpg-to-pdf' ? COPY : WORD_COPY; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
//Create Fake Widget |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
//Create Fake Widget |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
createTag.then((tag) => { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const wrapper = tag('div', {id: 'CID', class: `fsw widget-wrapper wapper-${VERB}` }); |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
const wrapper = tag('div', {id: 'CID', class: `fsw widget-wrapper wapper-${VERB}` }); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const heading = tag('h1', { class: 'widget-heading' }, dynamicHead); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const center = tag('div', { class: 'widget-center' }); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const copy = tag('p', { class: 'widget-copy' }, dynamicCopy); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const legal = tag('p', { class: 'widget-legal' }, LEGAL); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const button = tag('p', { class: 'widget-button' }, BTN); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
wrapper.append(heading); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
wrapper.append(center) |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 181 to 182 in 7e157f2
wrapper.append(center) | |
center.append(copy); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
center.append(copy); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
center.append(button); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
wrapper.append(legal); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
element.append(wrapper); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const dcWidgetScript = tag('script', { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
id: 'adobe_dc_sdk_launcher', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
src: WIDGET_ENV, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-dropzone_id': 'CID', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-locale': pageLang, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-server_env': ENV, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-verb': VERB, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-load_typekit': 'false', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-load_imslib': 'false', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-enable_unload_prompt': 'true', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// element.prepend(dcWidgetScript); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
document.addEventListener('milo:deferred', ()=> { |
🚫 [eslint] <arrow-spacing> reported by reviewdog 🐶
Missing space before =>.
document.addEventListener('milo:deferred', ()=> { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
wrapper.classList.add('widget-loaded'); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
element.prepend(dcWidgetScript); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 203 to 204 in 7e157f2
}) | |
// setTimeout(() => { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// setTimeout(() => { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// wrapper.classList.add('widget-loaded'); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// console.log('load widget'); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// element.prepend(dcWidgetScript); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// }, 5000) |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
// Generate cache url |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
const GENERATE_CACHE_URL_DIV = widget.querySelectorAll('div')[4]; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
if (GENERATE_CACHE_URL_DIV) { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
// GENERATE_CACHE_URL_DIV.id = 'GENERATE_CACHE_URL'; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
DC_GENERATE_CACHE_URL = GENERATE_CACHE_URL_DIV.textContent.trim(); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'DC_GENERATE_CACHE_URL' is assigned a value but never used.
DC_GENERATE_CACHE_URL = GENERATE_CACHE_URL_DIV.textContent.trim(); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
GENERATE_CACHE_URL_DIV.remove(); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
🚫 [eslint] <import/no-unresolved> reported by reviewdog 🐶
Unable to resolve path to module '../../scripts/legacyBrowser.js'.
const { redirectLegacyBrowsers } = await import('../../scripts/legacyBrowser.js'); |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 253 to 254 in 7e157f2
}) | |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'evt' is never reassigned. Use 'const' instead.
evt = new CustomEvent('dc.imslib.ready', { detail: { instance: window.adobeIMS }}); |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
evt = new CustomEvent('dc.imslib.ready', { detail: { instance: window.adobeIMS }}); |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 263 to 264 in 7e157f2
}) | |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
//import init from '../../../acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb'; |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
'utf8' | |
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.performance.mark = jest.fn(); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
jest.clearAllMocks(); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'fetchUrl' is assigned a value but never used.
let fetchUrl = ''; |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
fetch is not supported in op_mini all
window.fetch = jest.fn((url) => { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.fetch = jest.fn((url) => { |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
return Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://www.adobe.com'); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(launcher.getAttribute('src')).toMatch(/^https:\/\/acrobat.adobe.com\//); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
fetch is not supported in op_mini all
window.fetch = jest.fn((url) => { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.fetch = jest.fn((url) => { |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
return Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL(`https://${hostname}`); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(launcher.getAttribute('src')).toMatch(/^https:\/\/stage.acrobat.adobe.com\//); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
expect(launcher.getAttribute('src')).toMatch(/^https:\/\/stage.acrobat.adobe.com\//); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
fetch is not supported in op_mini all
window.fetch = jest.fn(() => |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.fetch = jest.fn(() => |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve({ |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve({ |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
Promise.resolve({ |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
}) | |
); |
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://www.adobe.com'); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(document.querySelector('#CID').children).toHaveLength(3); |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve({ |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
}) | |
); |
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
window.adobeIMS = { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
isSignedInUser: jest.fn(() => true) |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 100 to 101 in 7e157f2
isSignedInUser: jest.fn(() => true) | |
}; |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL(`https://${hostname}`); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(window.location).toMatch(/^https:\/\/www.adobe.com\/go\/acrobat-/); |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve({ |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 120 to 121 in 7e157f2
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 122 to 123 in 7e157f2
}) | |
); |
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
window.adobeIMS = { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
isSignedInUser: jest.fn(() => true) |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 125 to 126 in 7e157f2
isSignedInUser: jest.fn(() => true) | |
}; |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL(`https://${hostname}`); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
//expect(window.location).toMatch(/https:\/\/www.adobe.com\/go\/testredirect/); |
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension "js" for "../../../acrobat/scripts/contentSecurityPolicy/csp"
import ContentSecurityPolicy from '../../../acrobat/scripts/contentSecurityPolicy/csp'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'hostnameGetter' is defined but never used.
let hostnameGetter; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'url' is defined but never used.
let url; |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://www.adobe.com/acrobat/online/test'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://localhost:2000/acrobat/online/test'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
Line 4 in 7e157f2
//import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 14 to 16 in 7e157f2
window.location = new URL( | |
'https://www.adobe.com' | |
); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
Lines 15 to 16 in 7e157f2
'https://www.adobe.com' | |
); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 16 in 7e157f2
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'setLibs' is not defined.
Line 17 in 7e157f2
const libs = setLibs('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 18 in 7e157f2
expect(libs).toBe('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 19 in 7e157f2
expect(getLibs()).toBe('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'getLibs' is not defined.
Line 19 in 7e157f2
expect(getLibs()).toBe('/libs'); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 24 to 26 in 7e157f2
window.location = new URL( | |
'https://www.stage.adobe.com' | |
); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
Lines 25 to 26 in 7e157f2
'https://www.stage.adobe.com' | |
); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 26 in 7e157f2
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'setLibs' is not defined.
Line 27 in 7e157f2
const libs = setLibs('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 28 in 7e157f2
expect(libs).toBe('https://www.adobe.com/libs'); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 29 in 7e157f2
}); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 33 to 35 in 7e157f2
window.location = new URL( | |
'https://www.stage.adobe.com?milolibs=local' | |
); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
Lines 34 to 35 in 7e157f2
'https://www.stage.adobe.com?milolibs=local' | |
); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 35 in 7e157f2
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'setLibs' is not defined.
Line 36 in 7e157f2
const libs = setLibs('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 37 in 7e157f2
expect(libs).toBe('http://localhost:6456/libs'); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 42 to 44 in 7e157f2
window.location = new URL( | |
'https://www.stage.adobe.com?milolibs=main--milo--tsayadobe' | |
); |
🚫 [eslint] <import/order> reported by reviewdog 🐶../../acrobat/scripts/utils
import should occur after import of @esm-bundle/chai
Line 1 in 7e157f2
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'getLibs' is defined but never used.
Line 1 in 7e157f2
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension "js" for "../../acrobat/scripts/utils"
Line 1 in 7e157f2
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'sinon' is defined but never used.
Line 2 in 7e157f2
import * as sinon from 'sinon'; |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(!eventWrappers.length){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/eventWrapper.js
Lines 16 to 18 in 7e157f2
if(!eventWrappers.length){ | |
return; | |
} |
🚫 [eslint] <no-confusing-arrow> reported by reviewdog 🐶
Arrow function used ambiguously with a conditional expression.
const eventWrapper = Array.from(eventWrappers).filter((wrapper) => wrapper.querySelector(':scope > div').getAttribute('data-event-name') === 'onload' ? wrapper : wrapper.remove()); |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(!eventWrapper[0]){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/eventWrapper.js
Lines 22 to 24 in 7e157f2
if(!eventWrapper[0]){ | |
return; | |
} |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(dataPath && dataPath.includes('caas')){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/eventWrapper.js
Lines 29 to 31 in 7e157f2
if(dataPath && dataPath.includes('caas')){ | |
fragmentTypes.splice(3, 0, 'caas'); | |
} |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
const urlObject = new URL(url); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/tools/importScript/rules/eventWrapper.js
Lines 53 to 54 in 7e157f2
document | |
); |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/tools/importScript/rules/eventWrapper.js
Lines 62 to 63 in 7e157f2
} | |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'WebImporter' is not defined.
dc/tools/importScript/rules/metaData.js
Line 30 in 7e157f2
const block = WebImporter.Blocks.getMetadataBlock(document, meta); |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(!fragments.length) { |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
dc/tools/importScript/rules/verbFooter.js
Line 15 in 7e157f2
if(dataPath1 && dataPath1.includes('shell')){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/verbFooter.js
Lines 15 to 21 in 7e157f2
if(dataPath1 && dataPath1.includes('shell')){ | |
fragment.before(document.createElement('hr')); | |
fragment.after(document.createElement('hr')); | |
fragment.replaceWith(verbFragmentLink); | |
return; | |
} |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
dc/tools/importScript/rules/verbFooter.js
Line 24 in 7e157f2
if(dataPath2 && dataPath2.includes('verb-footer')){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/verbFooter.js
Lines 24 to 30 in 7e157f2
if(dataPath2 && dataPath2.includes('verb-footer')){ | |
fragment.before(document.createElement('hr')); | |
fragment.after(document.createElement('hr')); | |
fragment.replaceWith(verbFragmentLink); | |
return; | |
} |
🚫 [eslint] <no-useless-return> reported by reviewdog 🐶
Unnecessary return statement.
dc/tools/importScript/rules/verbFooter.js
Line 29 in 7e157f2
return; |
🚫 [eslint] <padded-blocks> reported by reviewdog 🐶
Block must not be padded by blank lines.
dc/tools/importScript/rules/verbFooter.js
Lines 31 to 33 in 7e157f2
}); | |
} |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/tools/importScript/rules/verbFooter.js
Lines 33 to 34 in 7e157f2
} | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'gr_en' found.
'gr_en': 'en-gr', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'gr_el' found.
'gr_el': 'el-gr', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ie' found.
'ie': 'en-ie', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'nl' found.
'nl': 'nl-nl', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'no' found.
'no': 'nb-no', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'at' found.
'at': 'de-at', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pl' found.
'pl': 'pl-pl', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pt' found.
'pt': 'pt-pt', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'bg' found.
'bg': 'bg-bg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ru' found.
'ru': 'ru-ru', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ua' found.
'ua': 'uk-ua', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'au' found.
'au': 'en-au', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'hk_en' found.
'hk_en': 'en-hk', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'in' found.
'in': 'en-in', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'in_hi' found.
'in_hi': 'hi-in', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'nz' found.
'nz': 'en-nz', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'hk_zh' found.
'hk_zh': 'zh-hant-hk', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'tw' found.
'tw': 'zh-hant-tw', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'jp' found.
'jp': 'ja-jp', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'kr' found.
'kr': 'ko-kr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ae_en' found.
'ae_en': 'en-ae', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ae_ar' found.
'ae_ar': 'ar-ae', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sa_en' found.
'sa_en': 'en-sa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sa_ar' found.
'sa_ar': 'ar-sa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'th_en' found.
'th_en': 'en-th', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'th_th' found.
'th_th': 'th-th', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sg' found.
'sg': 'en-sg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'cl' found.
'cl': 'es-cl', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'co' found.
'co': 'es-co', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ar' found.
'ar': 'es-ar', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'cr' found.
'cr': 'es-cr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pr' found.
'pr': 'es-pr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ec' found.
'ec': 'es-ec', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pe' found.
'pe': 'es-pe', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'eg_en' found.
'eg_en': 'en-eg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'eg_ar' found.
'eg_ar': 'ar-eg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'gt' found.
'gt': 'es-gt', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'id_en' found.
'id_en': 'en-id', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'id_id' found.
'id_id': 'in-id', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ph_en' found.
'ph_en': 'en-ph', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ph_fil' found.
'ph_fil': 'fil-ph', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'my_en' found.
'my_en': 'en-my', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'my_ms' found.
'my_ms': 'ms-my', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'kw_en' found.
'kw_en': 'en-kw', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'kw_ar' found.
'kw_ar': 'ar-kw', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ng' found.
'ng': 'en-ng', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'qa_en' found.
'qa_en': 'en-qa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'qa_ar' found.
'qa_ar': 'ar-qa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'vn_en' found.
'vn_en': 'en-vn', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'vn_vi' found.
'vn_vi': 'vi-vn' |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
'vn_vi': 'vi-vn' | |
}; |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'createpdf' found.
'createpdf': 'createpdf', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sendforsignature' found.
'sendforsignature': 'sendforsignature', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'fillsign' found.
'fillsign': 'fillsign', |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'url' is never reassigned. Use 'const' instead.
let url = new URL(window.location.href); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
let url = new URL(window.location.href); |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'langFromPath' is never reassigned. Use 'const' instead.
let langFromPath = url.pathname.split('/')[1]; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'DC_GENERATE_CACHE_VERSION_FALLBACK' is assigned a value but never used.
const DC_GENERATE_CACHE_VERSION_FALLBACK = '1.172.1'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'DC_GENERATE_CACHE_VERSION' is assigned a value but never used.
DC_GENERATE_CACHE_VERSION = STG_DC_GENERATE_CACHE_VERSION; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
const dynamicHead = VERB === 'jpg-to-pdf' ? HEADING : WORD_HEADING; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
const dynamicCopy = VERB === 'jpg-to-pdf' ? COPY : WORD_COPY; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
//Create Fake Widget |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
//Create Fake Widget |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
createTag.then((tag) => { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const wrapper = tag('div', {id: 'CID', class: `fsw widget-wrapper wapper-${VERB}` }); |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
const wrapper = tag('div', {id: 'CID', class: `fsw widget-wrapper wapper-${VERB}` }); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const heading = tag('h1', { class: 'widget-heading' }, dynamicHead); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const center = tag('div', { class: 'widget-center' }); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const copy = tag('p', { class: 'widget-copy' }, dynamicCopy); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const legal = tag('p', { class: 'widget-legal' }, LEGAL); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const button = tag('p', { class: 'widget-button' }, BTN); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
wrapper.append(heading); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
wrapper.append(center) |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 181 to 182 in 7e157f2
wrapper.append(center) | |
center.append(copy); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
center.append(copy); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
center.append(button); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
wrapper.append(legal); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
element.append(wrapper); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const dcWidgetScript = tag('script', { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
id: 'adobe_dc_sdk_launcher', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
src: WIDGET_ENV, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-dropzone_id': 'CID', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-locale': pageLang, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-server_env': ENV, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-verb': VERB, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-load_typekit': 'false', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-load_imslib': 'false', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-enable_unload_prompt': 'true', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// element.prepend(dcWidgetScript); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
document.addEventListener('milo:deferred', ()=> { |
🚫 [eslint] <arrow-spacing> reported by reviewdog 🐶
Missing space before =>.
document.addEventListener('milo:deferred', ()=> { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
wrapper.classList.add('widget-loaded'); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
element.prepend(dcWidgetScript); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 203 to 204 in 7e157f2
}) | |
// setTimeout(() => { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// setTimeout(() => { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// wrapper.classList.add('widget-loaded'); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// console.log('load widget'); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// element.prepend(dcWidgetScript); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// }, 5000) |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
// Generate cache url |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
const GENERATE_CACHE_URL_DIV = widget.querySelectorAll('div')[4]; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
if (GENERATE_CACHE_URL_DIV) { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
// GENERATE_CACHE_URL_DIV.id = 'GENERATE_CACHE_URL'; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
DC_GENERATE_CACHE_URL = GENERATE_CACHE_URL_DIV.textContent.trim(); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'DC_GENERATE_CACHE_URL' is assigned a value but never used.
DC_GENERATE_CACHE_URL = GENERATE_CACHE_URL_DIV.textContent.trim(); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
GENERATE_CACHE_URL_DIV.remove(); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
🚫 [eslint] <import/no-unresolved> reported by reviewdog 🐶
Unable to resolve path to module '../../scripts/legacyBrowser.js'.
const { redirectLegacyBrowsers } = await import('../../scripts/legacyBrowser.js'); |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 253 to 254 in 7e157f2
}) | |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'evt' is never reassigned. Use 'const' instead.
evt = new CustomEvent('dc.imslib.ready', { detail: { instance: window.adobeIMS }}); |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
evt = new CustomEvent('dc.imslib.ready', { detail: { instance: window.adobeIMS }}); |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 263 to 264 in 7e157f2
}) | |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
//import init from '../../../acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb'; |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
'utf8' | |
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.performance.mark = jest.fn(); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
jest.clearAllMocks(); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'fetchUrl' is assigned a value but never used.
let fetchUrl = ''; |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
fetch is not supported in op_mini all
window.fetch = jest.fn((url) => { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.fetch = jest.fn((url) => { |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
return Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://www.adobe.com'); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(launcher.getAttribute('src')).toMatch(/^https:\/\/acrobat.adobe.com\//); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
fetch is not supported in op_mini all
window.fetch = jest.fn((url) => { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.fetch = jest.fn((url) => { |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
return Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL(`https://${hostname}`); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(launcher.getAttribute('src')).toMatch(/^https:\/\/stage.acrobat.adobe.com\//); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
expect(launcher.getAttribute('src')).toMatch(/^https:\/\/stage.acrobat.adobe.com\//); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
fetch is not supported in op_mini all
window.fetch = jest.fn(() => |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.fetch = jest.fn(() => |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve({ |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve({ |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
Promise.resolve({ |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
}) | |
); |
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://www.adobe.com'); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(document.querySelector('#CID').children).toHaveLength(3); |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve({ |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
}) | |
); |
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
window.adobeIMS = { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
isSignedInUser: jest.fn(() => true) |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 100 to 101 in 7e157f2
isSignedInUser: jest.fn(() => true) | |
}; |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL(`https://${hostname}`); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(window.location).toMatch(/^https:\/\/www.adobe.com\/go\/acrobat-/); |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve({ |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 120 to 121 in 7e157f2
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 122 to 123 in 7e157f2
}) | |
); |
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
window.adobeIMS = { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
isSignedInUser: jest.fn(() => true) |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 125 to 126 in 7e157f2
isSignedInUser: jest.fn(() => true) | |
}; |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL(`https://${hostname}`); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
//expect(window.location).toMatch(/https:\/\/www.adobe.com\/go\/testredirect/); |
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension "js" for "../../../acrobat/scripts/contentSecurityPolicy/csp"
import ContentSecurityPolicy from '../../../acrobat/scripts/contentSecurityPolicy/csp'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'hostnameGetter' is defined but never used.
let hostnameGetter; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'url' is defined but never used.
let url; |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://www.adobe.com/acrobat/online/test'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://localhost:2000/acrobat/online/test'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
Line 4 in 7e157f2
//import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 14 to 16 in 7e157f2
window.location = new URL( | |
'https://www.adobe.com' | |
); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
Lines 15 to 16 in 7e157f2
'https://www.adobe.com' | |
); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 16 in 7e157f2
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'setLibs' is not defined.
Line 17 in 7e157f2
const libs = setLibs('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 18 in 7e157f2
expect(libs).toBe('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 19 in 7e157f2
expect(getLibs()).toBe('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'getLibs' is not defined.
Line 19 in 7e157f2
expect(getLibs()).toBe('/libs'); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 24 to 26 in 7e157f2
window.location = new URL( | |
'https://www.stage.adobe.com' | |
); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
Lines 25 to 26 in 7e157f2
'https://www.stage.adobe.com' | |
); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 26 in 7e157f2
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'setLibs' is not defined.
Line 27 in 7e157f2
const libs = setLibs('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 28 in 7e157f2
expect(libs).toBe('https://www.adobe.com/libs'); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 29 in 7e157f2
}); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 33 to 35 in 7e157f2
window.location = new URL( | |
'https://www.stage.adobe.com?milolibs=local' | |
); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
Lines 34 to 35 in 7e157f2
'https://www.stage.adobe.com?milolibs=local' | |
); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 35 in 7e157f2
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'setLibs' is not defined.
Line 36 in 7e157f2
const libs = setLibs('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 37 in 7e157f2
expect(libs).toBe('http://localhost:6456/libs'); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 42 to 44 in 7e157f2
window.location = new URL( | |
'https://www.stage.adobe.com?milolibs=main--milo--tsayadobe' | |
); |
🚫 [eslint] <import/order> reported by reviewdog 🐶../../acrobat/scripts/utils
import should occur after import of @esm-bundle/chai
Line 1 in 7e157f2
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'getLibs' is defined but never used.
Line 1 in 7e157f2
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension "js" for "../../acrobat/scripts/utils"
Line 1 in 7e157f2
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'sinon' is defined but never used.
Line 2 in 7e157f2
import * as sinon from 'sinon'; |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(!eventWrappers.length){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/eventWrapper.js
Lines 16 to 18 in 7e157f2
if(!eventWrappers.length){ | |
return; | |
} |
🚫 [eslint] <no-confusing-arrow> reported by reviewdog 🐶
Arrow function used ambiguously with a conditional expression.
const eventWrapper = Array.from(eventWrappers).filter((wrapper) => wrapper.querySelector(':scope > div').getAttribute('data-event-name') === 'onload' ? wrapper : wrapper.remove()); |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(!eventWrapper[0]){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/eventWrapper.js
Lines 22 to 24 in 7e157f2
if(!eventWrapper[0]){ | |
return; | |
} |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(dataPath && dataPath.includes('caas')){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/eventWrapper.js
Lines 29 to 31 in 7e157f2
if(dataPath && dataPath.includes('caas')){ | |
fragmentTypes.splice(3, 0, 'caas'); | |
} |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
const urlObject = new URL(url); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/tools/importScript/rules/eventWrapper.js
Lines 53 to 54 in 7e157f2
document | |
); |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/tools/importScript/rules/eventWrapper.js
Lines 62 to 63 in 7e157f2
} | |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'WebImporter' is not defined.
dc/tools/importScript/rules/metaData.js
Line 30 in 7e157f2
const block = WebImporter.Blocks.getMetadataBlock(document, meta); |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(!fragments.length) { |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
dc/tools/importScript/rules/verbFooter.js
Line 15 in 7e157f2
if(dataPath1 && dataPath1.includes('shell')){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/verbFooter.js
Lines 15 to 21 in 7e157f2
if(dataPath1 && dataPath1.includes('shell')){ | |
fragment.before(document.createElement('hr')); | |
fragment.after(document.createElement('hr')); | |
fragment.replaceWith(verbFragmentLink); | |
return; | |
} |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
dc/tools/importScript/rules/verbFooter.js
Line 24 in 7e157f2
if(dataPath2 && dataPath2.includes('verb-footer')){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/verbFooter.js
Lines 24 to 30 in 7e157f2
if(dataPath2 && dataPath2.includes('verb-footer')){ | |
fragment.before(document.createElement('hr')); | |
fragment.after(document.createElement('hr')); | |
fragment.replaceWith(verbFragmentLink); | |
return; | |
} |
🚫 [eslint] <no-useless-return> reported by reviewdog 🐶
Unnecessary return statement.
dc/tools/importScript/rules/verbFooter.js
Line 29 in 7e157f2
return; |
🚫 [eslint] <padded-blocks> reported by reviewdog 🐶
Block must not be padded by blank lines.
dc/tools/importScript/rules/verbFooter.js
Lines 31 to 33 in 7e157f2
}); | |
} |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/tools/importScript/rules/verbFooter.js
Lines 33 to 34 in 7e157f2
} | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ro' found.
'ro': 'ro-ro', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ch_de' found.
'ch_de': 'de-ch', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'si' found.
'si': 'sl-si', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sk' found.
'sk': 'sk-sk', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ch_fr' found.
'ch_fr': 'fr-ch', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'fi' found.
'fi': 'fi-fi', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'se' found.
'se': 'sv-se', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ch_it' found.
'ch_it': 'it-ch', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'tr' found.
'tr': 'tr-tr', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'uk' found.
'uk': 'en-uk', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'jp' found.
'jp': 'ja-jp', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'kr' found.
'kr': 'ko-kr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ae_en' found.
'ae_en': 'en-ae', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ae_ar' found.
'ae_ar': 'ar-ae', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sa_en' found.
'sa_en': 'en-sa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sa_ar' found.
'sa_ar': 'ar-sa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'th_en' found.
'th_en': 'en-th', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'th_th' found.
'th_th': 'th-th', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sg' found.
'sg': 'en-sg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'cl' found.
'cl': 'es-cl', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'co' found.
'co': 'es-co', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ar' found.
'ar': 'es-ar', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'cr' found.
'cr': 'es-cr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pr' found.
'pr': 'es-pr', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ec' found.
'ec': 'es-ec', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'pe' found.
'pe': 'es-pe', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'eg_en' found.
'eg_en': 'en-eg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'eg_ar' found.
'eg_ar': 'ar-eg', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'gt' found.
'gt': 'es-gt', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'id_en' found.
'id_en': 'en-id', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'id_id' found.
'id_id': 'in-id', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ph_en' found.
'ph_en': 'en-ph', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ph_fil' found.
'ph_fil': 'fil-ph', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'my_en' found.
'my_en': 'en-my', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'my_ms' found.
'my_ms': 'ms-my', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'kw_en' found.
'kw_en': 'en-kw', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'kw_ar' found.
'kw_ar': 'ar-kw', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ng' found.
'ng': 'en-ng', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'qa_en' found.
'qa_en': 'en-qa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'qa_ar' found.
'qa_ar': 'ar-qa', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'vn_en' found.
'vn_en': 'en-vn', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'vn_vi' found.
'vn_vi': 'vi-vn' |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
'vn_vi': 'vi-vn' | |
}; |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'createpdf' found.
'createpdf': 'createpdf', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'sendforsignature' found.
'sendforsignature': 'sendforsignature', |
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'fillsign' found.
'fillsign': 'fillsign', |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'url' is never reassigned. Use 'const' instead.
let url = new URL(window.location.href); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
let url = new URL(window.location.href); |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'langFromPath' is never reassigned. Use 'const' instead.
let langFromPath = url.pathname.split('/')[1]; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'DC_GENERATE_CACHE_VERSION_FALLBACK' is assigned a value but never used.
const DC_GENERATE_CACHE_VERSION_FALLBACK = '1.172.1'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'DC_GENERATE_CACHE_VERSION' is assigned a value but never used.
DC_GENERATE_CACHE_VERSION = STG_DC_GENERATE_CACHE_VERSION; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
const dynamicHead = VERB === 'jpg-to-pdf' ? HEADING : WORD_HEADING; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
const dynamicCopy = VERB === 'jpg-to-pdf' ? COPY : WORD_COPY; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
//Create Fake Widget |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
//Create Fake Widget |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
createTag.then((tag) => { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const wrapper = tag('div', {id: 'CID', class: `fsw widget-wrapper wapper-${VERB}` }); |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required after '{'.
const wrapper = tag('div', {id: 'CID', class: `fsw widget-wrapper wapper-${VERB}` }); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const heading = tag('h1', { class: 'widget-heading' }, dynamicHead); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const center = tag('div', { class: 'widget-center' }); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const copy = tag('p', { class: 'widget-copy' }, dynamicCopy); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const legal = tag('p', { class: 'widget-legal' }, LEGAL); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const button = tag('p', { class: 'widget-button' }, BTN); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
wrapper.append(heading); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
wrapper.append(center) |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 181 to 182 in de335e0
wrapper.append(center) | |
center.append(copy); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
center.append(copy); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
center.append(button); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
wrapper.append(legal); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
element.append(wrapper); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
const dcWidgetScript = tag('script', { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
id: 'adobe_dc_sdk_launcher', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
src: WIDGET_ENV, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-dropzone_id': 'CID', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-locale': pageLang, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-server_env': ENV, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-verb': VERB, |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-load_typekit': 'false', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-load_imslib': 'false', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
'data-enable_unload_prompt': 'true', |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// element.prepend(dcWidgetScript); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
document.addEventListener('milo:deferred', ()=> { |
🚫 [eslint] <arrow-spacing> reported by reviewdog 🐶
Missing space before =>.
document.addEventListener('milo:deferred', ()=> { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
wrapper.classList.add('widget-loaded'); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 6 spaces but found 10.
element.prepend(dcWidgetScript); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 203 to 204 in de335e0
}) | |
// setTimeout(() => { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// setTimeout(() => { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// wrapper.classList.add('widget-loaded'); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// console.log('load widget'); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// element.prepend(dcWidgetScript); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 8.
// }, 5000) |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 6.
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
// Generate cache url |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
const GENERATE_CACHE_URL_DIV = widget.querySelectorAll('div')[4]; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
if (GENERATE_CACHE_URL_DIV) { |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
// GENERATE_CACHE_URL_DIV.id = 'GENERATE_CACHE_URL'; |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
DC_GENERATE_CACHE_URL = GENERATE_CACHE_URL_DIV.textContent.trim(); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'DC_GENERATE_CACHE_URL' is assigned a value but never used.
DC_GENERATE_CACHE_URL = GENERATE_CACHE_URL_DIV.textContent.trim(); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 4 spaces but found 6.
GENERATE_CACHE_URL_DIV.remove(); |
🚫 [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 2 spaces but found 4.
🚫 [eslint] <import/no-unresolved> reported by reviewdog 🐶
Unable to resolve path to module '../../scripts/legacyBrowser.js'.
const { redirectLegacyBrowsers } = await import('../../scripts/legacyBrowser.js'); |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 253 to 254 in de335e0
}) | |
🚫 [eslint] <prefer-const> reported by reviewdog 🐶
'evt' is never reassigned. Use 'const' instead.
evt = new CustomEvent('dc.imslib.ready', { detail: { instance: window.adobeIMS }}); |
🚫 [eslint] <object-curly-spacing> reported by reviewdog 🐶
A space is required before '}'.
evt = new CustomEvent('dc.imslib.ready', { detail: { instance: window.adobeIMS }}); |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.js
Lines 263 to 264 in de335e0
}) | |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
//import init from '../../../acrobat/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb'; |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
'utf8' | |
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.performance.mark = jest.fn(); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
jest.clearAllMocks(); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'fetchUrl' is assigned a value but never used.
let fetchUrl = ''; |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
fetch is not supported in op_mini all
window.fetch = jest.fn((url) => { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.fetch = jest.fn((url) => { |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
return Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://www.adobe.com'); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(launcher.getAttribute('src')).toMatch(/^https:\/\/acrobat.adobe.com\//); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
fetch is not supported in op_mini all
window.fetch = jest.fn((url) => { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.fetch = jest.fn((url) => { |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
return Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL(`https://${hostname}`); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(launcher.getAttribute('src')).toMatch(/^https:\/\/stage.acrobat.adobe.com\//); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
expect(launcher.getAttribute('src')).toMatch(/^https:\/\/stage.acrobat.adobe.com\//); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
fetch is not supported in op_mini all
window.fetch = jest.fn(() => |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
window.fetch = jest.fn(() => |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve({ |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve({ |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
Promise.resolve({ |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
}) | |
); |
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://www.adobe.com'); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(document.querySelector('#CID').children).toHaveLength(3); |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve({ |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
}) | |
); |
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
window.adobeIMS = { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
isSignedInUser: jest.fn(() => true) |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 100 to 101 in de335e0
isSignedInUser: jest.fn(() => true) | |
}; |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL(`https://${hostname}`); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(window.location).toMatch(/^https:\/\/www.adobe.com\/go\/acrobat-/); |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve({ |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve({ |
🚫 [eslint] <implicit-arrow-linebreak> reported by reviewdog 🐶
Expected no linebreak before this expression.
Promise.resolve( |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
Promise.resolve() is not supported in op_mini all
Promise.resolve( |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 120 to 121 in de335e0
fs.readFileSync(path.resolve(__dirname, './mocks/widget.html')) | |
), |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 122 to 123 in de335e0
}) | |
); |
🚫 [eslint] <function-paren-newline> reported by reviewdog 🐶
Unexpected newline before ')'.
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break after this opening brace.
window.adobeIMS = { |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'jest' is not defined.
isSignedInUser: jest.fn(() => true) |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/test/blocks/dc-converter-widget-ootb/dc-converter-widget-ootb.jest.js
Lines 125 to 126 in de335e0
isSignedInUser: jest.fn(() => true) | |
}; |
🚫 [eslint] <object-curly-newline> reported by reviewdog 🐶
Unexpected line break before this closing brace.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL(`https://${hostname}`); |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'widget' is assigned a value but never used.
const widget = await init(block); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'init' is not defined.
const widget = await init(block); |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
//expect(window.location).toMatch(/https:\/\/www.adobe.com\/go\/testredirect/); |
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension "js" for "../../../acrobat/scripts/contentSecurityPolicy/csp"
import ContentSecurityPolicy from '../../../acrobat/scripts/contentSecurityPolicy/csp'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'hostnameGetter' is defined but never used.
let hostnameGetter; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'url' is defined but never used.
let url; |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://www.adobe.com/acrobat/online/test'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
window.location = new URL('https://localhost:2000/acrobat/online/test'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('http-equiv')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.hasAttribute('content')).toBe(true); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
expect(meta.getAttribute('http-equiv')).toBe('Content-Security-Policy'); |
🚫 [eslint] <spaced-comment> reported by reviewdog 🐶
Expected exception block, space or tab after '//' in comment.
Line 4 in de335e0
//import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 14 to 16 in de335e0
window.location = new URL( | |
'https://www.adobe.com' | |
); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
Lines 15 to 16 in de335e0
'https://www.adobe.com' | |
); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 16 in de335e0
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'setLibs' is not defined.
Line 17 in de335e0
const libs = setLibs('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 18 in de335e0
expect(libs).toBe('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 19 in de335e0
expect(getLibs()).toBe('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'getLibs' is not defined.
Line 19 in de335e0
expect(getLibs()).toBe('/libs'); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 24 to 26 in de335e0
window.location = new URL( | |
'https://www.stage.adobe.com' | |
); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
Lines 25 to 26 in de335e0
'https://www.stage.adobe.com' | |
); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 26 in de335e0
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'setLibs' is not defined.
Line 27 in de335e0
const libs = setLibs('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 28 in de335e0
expect(libs).toBe('https://www.adobe.com/libs'); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 29 in de335e0
}); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 33 to 35 in de335e0
window.location = new URL( | |
'https://www.stage.adobe.com?milolibs=local' | |
); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
Lines 34 to 35 in de335e0
'https://www.stage.adobe.com?milolibs=local' | |
); |
🚫 [eslint] <no-trailing-spaces> reported by reviewdog 🐶
Trailing spaces not allowed.
Line 35 in de335e0
); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'setLibs' is not defined.
Line 36 in de335e0
const libs = setLibs('/libs'); |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'expect' is not defined.
Line 37 in de335e0
expect(libs).toBe('http://localhost:6456/libs'); |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
Lines 42 to 44 in de335e0
window.location = new URL( | |
'https://www.stage.adobe.com?milolibs=main--milo--tsayadobe' | |
); |
🚫 [eslint] <import/order> reported by reviewdog 🐶../../acrobat/scripts/utils
import should occur after import of @esm-bundle/chai
Line 1 in de335e0
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'getLibs' is defined but never used.
Line 1 in de335e0
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension "js" for "../../acrobat/scripts/utils"
Line 1 in de335e0
import { setLibs, getLibs } from '../../acrobat/scripts/utils'; |
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'sinon' is defined but never used.
Line 2 in de335e0
import * as sinon from 'sinon'; |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(!eventWrappers.length){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/eventWrapper.js
Lines 16 to 18 in de335e0
if(!eventWrappers.length){ | |
return; | |
} |
🚫 [eslint] <no-confusing-arrow> reported by reviewdog 🐶
Arrow function used ambiguously with a conditional expression.
const eventWrapper = Array.from(eventWrappers).filter((wrapper) => wrapper.querySelector(':scope > div').getAttribute('data-event-name') === 'onload' ? wrapper : wrapper.remove()); |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(!eventWrapper[0]){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/eventWrapper.js
Lines 22 to 24 in de335e0
if(!eventWrapper[0]){ | |
return; | |
} |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(dataPath && dataPath.includes('caas')){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/eventWrapper.js
Lines 29 to 31 in de335e0
if(dataPath && dataPath.includes('caas')){ | |
fragmentTypes.splice(3, 0, 'caas'); | |
} |
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
const urlObject = new URL(url); |
🚫 [eslint] <comma-dangle> reported by reviewdog 🐶
Missing trailing comma.
dc/tools/importScript/rules/eventWrapper.js
Lines 53 to 54 in de335e0
document | |
); |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/tools/importScript/rules/eventWrapper.js
Lines 62 to 63 in de335e0
} | |
🚫 [eslint] <no-undef> reported by reviewdog 🐶
'WebImporter' is not defined.
dc/tools/importScript/rules/metaData.js
Line 30 in de335e0
const block = WebImporter.Blocks.getMetadataBlock(document, meta); |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
if(!fragments.length) { |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
dc/tools/importScript/rules/verbFooter.js
Line 15 in de335e0
if(dataPath1 && dataPath1.includes('shell')){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/verbFooter.js
Lines 15 to 21 in de335e0
if(dataPath1 && dataPath1.includes('shell')){ | |
fragment.before(document.createElement('hr')); | |
fragment.after(document.createElement('hr')); | |
fragment.replaceWith(verbFragmentLink); | |
return; | |
} |
🚫 [eslint] <keyword-spacing> reported by reviewdog 🐶
Expected space(s) after "if".
dc/tools/importScript/rules/verbFooter.js
Line 24 in de335e0
if(dataPath2 && dataPath2.includes('verb-footer')){ |
🚫 [eslint] <space-before-blocks> reported by reviewdog 🐶
Missing space before opening brace.
dc/tools/importScript/rules/verbFooter.js
Lines 24 to 30 in de335e0
if(dataPath2 && dataPath2.includes('verb-footer')){ | |
fragment.before(document.createElement('hr')); | |
fragment.after(document.createElement('hr')); | |
fragment.replaceWith(verbFragmentLink); | |
return; | |
} |
🚫 [eslint] <no-useless-return> reported by reviewdog 🐶
Unnecessary return statement.
dc/tools/importScript/rules/verbFooter.js
Line 29 in de335e0
return; |
🚫 [eslint] <padded-blocks> reported by reviewdog 🐶
Block must not be padded by blank lines.
dc/tools/importScript/rules/verbFooter.js
Lines 31 to 33 in de335e0
}); | |
} |
🚫 [eslint] <semi> reported by reviewdog 🐶
Missing semicolon.
dc/tools/importScript/rules/verbFooter.js
Lines 33 to 34 in de335e0
} | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'bg' found.
'bg': 'bg-bg', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ru' found.
'ru': 'ru-ru', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'ua' found.
'ua': 'uk-ua', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'au' found.
'au': 'en-au', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'hk_en' found.
'hk_en': 'en-hk', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'in' found.
'in': 'en-in', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'in_hi' found.
'in_hi': 'hi-in', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'nz' found.
'nz': 'en-nz', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'hk_zh' found.
'hk_zh': 'zh-hant-hk', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <quote-props> reported by reviewdog 🐶
Unnecessarily quoted property 'tw' found.
'tw': 'zh-hant-tw', |
Description
Upgrading to aem.live from hlx.live as per the product requirements and docs.
This is not meant to be a complete PR but a spike to ensure you have everything you need and should be carefully QA'd
Todo's
aem.page
andaem.live
hlx.live
orhlx.page
Test URLs
All 4 variations should work:
hlx.page
aem.page
hlx.live
aem.live
Before: https://stage--dc--adobecom.hlx.live/uk/acrobat/business/industries/government
After: https://hlx-5--dc--adobecom.aem.live/uk/acrobat/business/industries/government
After-2: https://hlx-5--dc--adobecom.hlx.live/uk/acrobat/business/industries/government
Known issues