MWPW-137930 DCXY-18989 if snippet is loaded inline, use it #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## stage #417 +/- ##
==========================================
- Coverage 96.61% 96.58% -0.03%
==========================================
Files 26 26
Lines 2985 2989 +4
==========================================
+ Hits 2884 2887 +3
- Misses 101 102 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
peller
force-pushed
the
edge-experiment
branch
from
707ffc1 to
2f61489
Compare
|
|
peller
force-pushed
the
edge-experiment
branch
from
c2c3279 to
72baadf
Compare
|
peller
force-pushed
the
edge-experiment
branch
from
72baadf to
0b84df5
Compare
|
|
peller
changed the title
|
| @@ -37,6 +37,18 @@ describe('dc-converter-widget', () => { | |||
| expect(fetchUrl).toMatch(/^https:\/\/www.adobe.com\/dc\//); | |||
| @@ -37,6 +37,18 @@ | |||
| expect(fetchUrl).toMatch(/^https:\/\/www.adobe.com\/dc\//); | |||
| }); | |||
|
|
|||
| it('handles content inserted from edge', async () => { | |||
| delete window.location; | |||
| window.location = new URL('https://www.adobe.com'); | |||
There was a problem hiding this comment.
🚫 [eslint] <compat/compat> reported by reviewdog 🐶
URL is not supported in op_mini all
| section.appendChild(document.createTextNode('content')); | ||
| block.appendChild(section); | ||
| const widget = await init(block); | ||
| expect(document.querySelector('#CID').dataset.rendered).toEqual("true"); |
|
| section.appendChild(document.createTextNode('content')); | ||
| block.appendChild(section); | ||
| await init(block); | ||
| expect(document.querySelector('#CID').dataset.rendered).toEqual('true'); |
|
| widgetContainer.dataset.rendered = 'true'; | ||
| widgetContainer.appendChild(...INLINE_SNIPPET.childNodes); | ||
| widget.removeChild(INLINE_SNIPPET); | ||
| cacheLoad = true; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edge worker will load the dc-generate-cache snippet and inline it in the HTML page in a section tag id="edge-snippet". If it's already there, use the DOM rather than fetch it over http.