Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the query-index #50

Closed
wants to merge 2 commits into from
Closed

Rename the query-index #50

wants to merge 2 commits into from

Conversation

mokimo
Copy link
Contributor

@mokimo mokimo commented Nov 13, 2024

The query-index does not exist and the yaml should be called helix-query - there's no way to test this other than on the main branch. This closes #26

This will need a second PR to change the milo core block to actually consume the helix-query rather than the query-index which is hardcoded.

And a third PR to remove the query-index reference, I don't want to touch this currently before ensuring the new setup works to avoid breaking the current setup.

Before: https://main--blog--adobecom.hlx.live/
After: https://fix-query--blog--adobecom.hlx.live/

Copy link

aem-code-sync bot commented Nov 13, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Nov 13, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice
I have a few comments

  1. once this change is made, you'll probably want to make sure that there's already a helix-query.json copy existing or you'll need to be ready to reindex the site with an API command right away. Are you planning for this already?
  2. it's possible to half test locally on a page by running aem up --print-index. That'll give you some guarantees that this kind of works. (only mentioning in case you didn't do that.)
  3. It probably also makes sense to time the go live of this branch pretty soon before we make the change to the block in milo. That way the experience for real users is disrupted as little as possible. I'm guessing you were already planning to do this, but asking anyway just to be sure :)

@mokimo
Copy link
Contributor Author

mokimo commented Nov 13, 2024

Before merging this, i first want to try the OOTB helix-query and see if we could use that. I'll close this in the meantime, because I think theres no going back when we merge this one. Still have a bit of homework to do with query indexes

@mokimo mokimo closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query-index.yaml should be named helix-query.yaml
3 participants