Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-160548: CTA Widget and Chat CTA style updates #273

Merged
merged 14 commits into from
Dec 12, 2024

Conversation

meganthecoder
Copy link
Contributor

Copy link

aem-code-sync bot commented Dec 10, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Sorry, something went wrong.

Copy link

aem-code-sync bot commented Dec 10, 2024

@meganthecoder meganthecoder changed the title [MWPW-160548] CTA Widget and Chat CTA style updates MWPW-160548: CTA Widget and Chat CTA style updates Dec 10, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to chat-cta-style-update December 10, 2024 19:15 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.80%. Comparing base (27c3028) to head (b39ea85).
Report is 44 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #273      +/-   ##
==========================================
+ Coverage   95.95%   96.80%   +0.85%     
==========================================
  Files          11       13       +2     
  Lines        1088     1379     +291     
==========================================
+ Hits         1044     1335     +291     
  Misses         44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JasonHowellSlavin JasonHowellSlavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aem-code-sync aem-code-sync bot temporarily deployed to chat-cta-style-update December 11, 2024 19:25 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to chat-cta-style-update December 11, 2024 20:16 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to chat-cta-style-update December 11, 2024 20:23 Inactive
@Dli3 Dli3 added verified it's been E2E tested by someone (that isn't the PR requestor) ready for stage labels Dec 11, 2024
@meganthecoder meganthecoder merged commit 47cee53 into stage Dec 12, 2024
9 checks passed
@meganthecoder meganthecoder deleted the chat-cta-style-update branch December 12, 2024 17:19
meganthecoder added a commit that referenced this pull request Dec 12, 2024
* Adding greybox to map

* MWPW-160548: CTA Widget and Chat CTA style updates (#273)

* Updated CSS to match current designs. Found a few issues that require discusssion

* Small tweaks to height and display:

* Adding new block, good way there

* Styles mostly all there, just need to get the 'modal' screen on mobile

* add curtain

* widget button style updates

* sync with figma styles

* unit tests

* fix mobile landscape

* change selector - safari 16 bug

* fix button color on safari

* hide scrollbar when not needed

---------

Co-authored-by: Jason Slavin <slavin@adobe.com>

---------

Co-authored-by: Jason Slavin <slavin@adobe.com>
Co-authored-by: Jason Slavin <slavin.jhs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for stage verified it's been E2E tested by someone (that isn't the PR requestor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants