Migrate BACOM to Helix 5 #272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overmyheadandbody
requested review from
meganthecoder,
Brandon32 and
JasonHowellSlavin
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #272 +/- ##
==========================================
+ Coverage 95.95% 96.71% +0.76%
==========================================
Files 11 12 +1
Lines 1088 1340 +252
==========================================
+ Hits 1044 1296 +252
Misses 44 44 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading to
.aem.from.hlx.as per the product requirements and docs.This is not meant to be a complete PR, just one that starts you off. This should be carefully tested.
Todo
aem.pageandaem.livehlx.liveorhlx.pagefrom the codebaseTest URLs
All variations should continue working:
(hlx|aem).(page|live)Before: https://main--bacom--adobecom.hlx.page/
After: https://hlx5--bacom--adobecom.hlx.page/
Before: https://stage--bacom--adobecom.hlx.page/ch_de/products/real-time-customer-data-platform/rtcdp
After: https://hlx5--bacom--adobecom.hlx.page/ch_de/products/real-time-customer-data-platform/rtcdp
Before: https://main--bacom--adobecom.aem.page/ (not working, code from this branch is needed)
After: https://hlx5--bacom--adobecom.aem.page/
Before: https://stage--bacom--adobecom.aem.page/ch_de/products/real-time-customer-data-platform/rtcdp (not working, code from this branch is needed)
After: https://hlx5--bacom--adobecom.aem.page/ch_de/products/real-time-customer-data-platform/rtcdp
Before: https://main--bacom--adobecom.hlx.live/
After: https://hlx5--bacom--adobecom.hlx.live/
Before: https://stage--bacom--adobecom.hlx.live/ch_de/products/real-time-customer-data-platform/rtcdp
After: https://hlx5--bacom--adobecom.hlx.live/ch_de/products/real-time-customer-data-platform/rtcdp
Before: https://main--bacom--adobecom.aem.live/ (not working, code from this branch is needed)
After: https://hlx5--bacom--adobecom.aem.live/
Before: https://stage--bacom--adobecom.aem.live/ch_de/products/real-time-customer-data-platform/rtcdp (not working, code from this branch is needed)
After: https://hlx5--bacom--adobecom.aem.live/ch_de/products/real-time-customer-data-platform/rtcdp
Known issues