Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-162313 Fix favicon on safari #267

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

meganthecoder
Copy link
Contributor

  • Add favicon at the root to resolve 404 on safari

Full explanation in discussion: https://github.com/orgs/adobecom/discussions/3230

Resolves: MWPW-162313

Test URLs:

Copy link

aem-code-sync bot commented Nov 20, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.70%. Comparing base (5cba023) to head (2aa537b).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #267   +/-   ##
=======================================
  Coverage   96.70%   96.70%           
=======================================
  Files          12       12           
  Lines        1335     1335           
=======================================
  Hits         1291     1291           
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@meganthecoder meganthecoder merged commit 9734f6b into adobecom:stage Nov 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants