Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack notification should be sent when docs are published #734

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

asthabh23
Copy link
Member

Description

This PR adds webhook-type for slack-github-action which currently fails sending notification on slack channel when docs are published

Related Issue

#733

Motivation and Context

This was working before a dependency update happened 2 weeks back, this PR will fix the issue.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

aem-code-sync bot commented Jan 7, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@asthabh23 asthabh23 linked an issue Jan 7, 2025 that may be closed by this pull request
@asthabh23 asthabh23 requested a review from trieloff January 7, 2025 06:46
@trieloff trieloff merged commit 33ddbcf into main Jan 7, 2025
3 of 4 checks passed
@trieloff trieloff deleted the issue-733 branch January 7, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack notification not sent when docs are published
2 participants