set metaboliteType validation rule as "list like" #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Suite ReportTemplate GenerationThe following manifest templates had at least one dependency with
🚧 Manifest Validation - COMING SOON |
avanlinden
requested review from
MasterPastures,
tmzintel and
ameliakallaher
|
Ok, I think this worked as expected and will now allow data contributors to enter a list of comma-separated values. The only downside is now there are no drop-downs for the various valid values, just a note to check the data standards (see screenshot). 
@tmzintel we should make sure to refer them to the AD metadata dictionary app to look up the specific metaboliteType values if they need them: https://www.synapse.org/Synapse:syn25878249 |
MasterPastures
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on documentation (https://sagebionetworks.jira.com/wiki/spaces/SCHEM/pages/2645262364/Data+Model+Validation+Rules#list) I think this will allow data contributors to provide a list of valid values, comma separated or otherwise, and have each of them validated against the data model. I am not sure whether this will result in multi-value annotations being applied to files in Synapse, though, so more work may need to be done.