Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unexpected shift of the entire article when anchor hidden = false #1649

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jabee0228
Copy link

@jabee0228 jabee0228 commented Dec 18, 2024

What does this PR change? What problem does it solve?

When a heading occupies an entire line, moving the mouse over the heading causes the entire article to unexpectedly shift down by one line.
And adjusted the anchor's underline to align with this modification.

Before:
before

After the fix, the following effects are achieved:
after
Line breaks will also be correct:
new
h1, h2, h3, h4, h5, and h6 all function correctly.

Was the change discussed in an issue or in the Discussions before?
No, this bug was found when I was writing an article.

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

When a heading occupies an entire line, moving the mouse over the heading causes the entire article to unexpectedly shift down by one line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant