Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Default seek, event.target, import await, forward scrubbing, fullscreen inview #311

Open
wants to merge 3 commits into
base: issue/298
Choose a base branch
from

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Jan 6, 2025

requires adaptlearning/adapt-contrib-core#612
fixes #304

Fix

  • import() returns a promise
  • android triggers timeupdate before seeking which prevents the seek blocking behaviour
  • defaultSeekBackwardInterval and defaultSeekForwardInterval need to be converted to functions from strings at runtime
  • onMediaElementTimeUpdate and onMediaElementSeeking do not have event.target on windows chrome use event.currentTarget instead
  • inview + fullscreen locking

@oliverfoster oliverfoster changed the title DefaultSeek, event.target, import await, prevent forward scrubbing android Fix: Default seek, event.target, import await, forward scrubbing, fullscreen inview Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Reviewing
Development

Successfully merging this pull request may close these issues.

1 participant