Fix builds on nodejs >=4 by updating electron-rebuild #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the last problematic dependency was nslog, but that got fixed and then added to a newer electron-rebuild. I don't actually know enought about the electron ecosystem to know if you might want to choose a slightly older dep here, or update other electron deps inline with this one. |
|
I realize that I don't have a nodejs 0.12.x to guarantee that it even works there. |
|
now tested with nodejs 4.1.2 and 4.2.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to work for me on Linux with nodejs 5.x, but should apply just
as well with nodejs 4.x.