Remove obsolete fly.template.toml #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like all reference to `fly.template.toml` was removed in https://github.com/actualbudget/docs/pull/127/files#diff-ba80a6d0a12ccccead81eadaae92be01447e628a44c6f82594d809dd5977499cL156-L162 in favor of using the [`fly.toml` from the docs repo](https://github.com/actualbudget/docs/blob/master/static/fly.toml). Current search in the actualbudget org only shows this file https://github.com/search?q=org%3Aactualbudget%20fly.template.toml&type=code
albertchae
force-pushed
the
remove-fly-template
branch
from
8163b04 to
75123d6
Compare
joel-jeremy
approved these changes
Jan 9, 2024
trafico-bot
bot
added
✅ Approved
MatissJanis
approved these changes
Jan 12, 2024
trafico-bot
bot
added
✨ Merged
MMichotte
pushed a commit
to MMichotte/actual-server
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like all reference to
fly.template.tomlwas removed inhttps://github.com/actualbudget/docs/pull/127/files#diff-ba80a6d0a12ccccead81eadaae92be01447e628a44c6f82594d809dd5977499cL156-L162
in favor of using the
fly.tomlfrom the docs repo.Current search in the actualbudget org only shows this file
https://github.com/search?q=org%3Aactualbudget%20fly.template.toml&type=code
I came across this because I was running into this issue #271, and apparently it was because when I followed the old instructions to use
fly.template.toml, it was missing amountssection for/data.Alternatively, if
fly.template.tomlis not obsolete and we do want to keep it, I think we should keep it in sync with thefly.tomlfrom docs or at the very least add themountssection. I can make that PR if that's preferable.