This repository has been archived by the owner on May 28, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #421
For every
requestSync
orreportState
request, a new JWTClient is created, causing a post request to get a new token:actions-on-google-nodejs/src/service/smarthome/smarthome.ts
Line 332 in eaa9e20
The token that is returned is valid for an hour, but the client and token are still recreated for every request.
With this PR, the JWTClient is created just once, on first use, this causes that the token is cached and only refreshed when it is no longer valid.
Furthermore, during the request of a new token, all other requests now wait for this token to finish loading instead of starting a new load.
This will drastically improve the performance and lower the number of requests to the Google Authentication API.
(Sorry, prettier doesn't seem agree with your style guidelines)