Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save bundle included events using a separate class #99

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

amateima
Copy link
Contributor

@amateima amateima commented Nov 12, 2024

Put the logic for saving bundle events in a new class BundleIncludedEventsService

@amateima amateima requested review from melisaguevara, james-a-morris and daywiss and removed request for melisaguevara and james-a-morris November 12, 2024 00:52
@amateima amateima changed the title fix: separate saving of bundle included events fix: save bundle included events using a separate class Nov 12, 2024
@amateima amateima force-pushed the amatei/executed-bundles-spoke-pool-events branch from a84c792 to 91f2222 Compare November 12, 2024 14:12
Copy link
Contributor

@melisaguevara melisaguevara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amateima amateima merged commit 63371b8 into master Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants