feat(webhooks): allow client registration through env #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: david <david@umaproject.org>
daywiss
commented
Nov 27, 2024
| // assert( | ||
| // isDomainValid, | ||
| // "The base URL of the provided webhook does not match any of the client domains", | ||
| // ); |
There was a problem hiding this comment.
removed domain checking for now
daywiss
commented
Nov 27, 2024
| @@ -2,6 +2,7 @@ import { Entity, Column, PrimaryGeneratedColumn, Unique } from "typeorm"; | |||
|
|
|||
| @Entity() | |||
| @Unique("UK_webhook_client_api_key", ["apiKey"]) | |||
| @Unique("UK_webhook_client_name", ["name"]) | |||
There was a problem hiding this comment.
i wnated to make a unique constraint for name, i dont know if i did this right because i have no idea what UK_webhook means
daywiss
commented
Nov 27, 2024
| @@ -0,0 +1,17 @@ | |||
| import { MigrationInterface, QueryRunner } from "typeorm"; | |||
|
|
|||
| export class Webhook1732730161339 implements MigrationInterface { | |||
There was a problem hiding this comment.
did the migration after adding uniquye name constraint, again dont know if this is correct
| @@ -87,10 +87,12 @@ export async function Main( | |||
| const postgres = await connectToDatabase(postgresConfig, logger); | |||
| const redisConfig = Indexer.parseRedisConfig(env); | |||
| const redis = await initializeRedis(redisConfig, logger); | |||
| const webhooks = Webhooks.WebhookFactory( | |||
| const webhooks = await Webhooks.WebhookFactory( | |||
There was a problem hiding this comment.
Usually a factory is a class that has a builder function on it. Is this Factory a function?
james-a-morris
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation
we need an easy way to add and update arbitrary webhook clients
changes
this adds env config var to regsiter new clients as well as removes domain checks to make it easier for testing