chore: replace info-level logs with debug #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melisaguevara
requested review from
amateima,
daywiss and
james-a-morris
and removed request for
amateima and
daywiss
packages/indexer-api/src/main.ts
Outdated
| @@ -28,8 +28,9 @@ async function initializeRedis( | |||
|
|
|||
| redis.on("error", (err) => { | |||
| logger.error({ | |||
| at: "Indexer-API", | |||
| at: "IndexerAPI", | |||
There was a problem hiding this comment.
We may want to specify what the function is. I.e. IndexerAPI#main
There was a problem hiding this comment.
Done here b59aa5c
| message: "No executed bundles found", | ||
| at: "resolveMostRecentProposedAndExecutedBundles", | ||
| notificationPath: "across-indexer-error", |
There was a problem hiding this comment.
ooc what is a notificationPath in this case?
There was a problem hiding this comment.
This is the key we use to send Slack messages to a specific channel.
Its value has to be part of the escalationPathWebhookUrls object in the SLACK_CONFIG env var.
Here's our config: https://github.com/UMAprotocol/zion/pull/429/files
We'll have a default channel for info and warns, and other channel just for errors
amateima
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use UMA's logger to send logs to slack, we should reduce the number of info logs in the indexer.
This PR:
Zion PR to config slack channels: https://github.com/UMAprotocol/zion/pull/429