Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-30489 Use WebView 2 based on Edge Chromium #6

Merged
merged 20 commits into from
Nov 28, 2023
Merged

Conversation

abhijeetnarvekar
Copy link
Contributor

@abhijeetnarvekar abhijeetnarvekar commented Sep 16, 2022

Use latest SDK from Github package registry

  • - Add Github Nuget source

Update function calls to SDK to use async

  • - Handle async calls
  • - Use async/await wherever required

Update readme

  • - Document usage of webview 2 and its requirements
  • - Update screenshots if needed

Add sample for for showMessage functionality

  • - Add a button on form to "Show Sidebar Message"
  • - Clicking should show a example message on Sidebar

@abhijeetnarvekar abhijeetnarvekar marked this pull request as draft September 16, 2022 12:14
@abhijeetnarvekar abhijeetnarvekar marked this pull request as ready for review September 19, 2022 09:11
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@pcdeshmukh pcdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//sidebar.SidebarSourceLocation = "http://yourlocalserver:8031/sidebar/v14/index.html";
Review commented code and remove unwanted/old code.

abhijeetnarvekar and others added 13 commits November 28, 2023 09:48
* Enable Dependabot updates for nuget and github-actions

Also enable Dependabot auto-merge

* Fix path to packages file
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…13)

Bumps [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) from 13.0.1 to 13.0.3.
- [Release notes](https://github.com/JamesNK/Newtonsoft.Json/releases)
- [Commits](JamesNK/Newtonsoft.Json@13.0.1...13.0.3)

---
updated-dependencies:
- dependency-name: Newtonsoft.Json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 2 to 3.
- [Release notes](https://github.com/actions/setup-dotnet/releases)
- [Commits](actions/setup-dotnet@v2...v3)

---
updated-dependencies:
- dependency-name: actions/setup-dotnet
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@abhijeetnarvekar
Copy link
Contributor Author

//sidebar.SidebarSourceLocation = "http://yourlocalserver:8031/sidebar/v14/index.html"; Review commented code and remove unwanted/old code.

Removed comment. Replaced http:// with https:// in example

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pcdeshmukh pcdeshmukh merged commit 32f8486 into main Nov 28, 2023
5 checks passed
@pcdeshmukh pcdeshmukh deleted the DEV-30489 branch November 28, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants