Add override of getString method #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyori19
requested changes
Dec 29, 2022
|
Sorry for delay, I had many things to do this week. Please update code according to my review, then I will merge this. |
|
No worries! I have force-pushed the branch to implement this |
kyori19
approved these changes
Dec 30, 2022
|
thanks @vlakoff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out on #16. This should make DevOptsHide work with more apps.
Thankfully, the
MethodHookParamobject has amethodproperty (see in XC_MethodHook.java), so we can make use of java.lang.reflect.Member.getName().(there are other ways to write this code, so maybe someone could think of a more factorized/performant implementation)