Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add privacy manifest #1604

Closed
wants to merge 1 commit into from
Closed

Add privacy manifest #1604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions PrivacyInfo.xcprivacy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>NSPrivacyTracking</key>
<false/>
<key>NSPrivacyCollectedDataTypes</key>
<array/>
<key>NSPrivacyTrackingDomains</key>
<array/>
<key>NSPrivacyAccessedAPITypes</key>
<array/>
</dict>
</plist>
3 changes: 3 additions & 0 deletions absl/abseil.podspec.gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@
:git => 'https://github.com/abseil/abseil-cpp.git',
:tag => '${tag}',
}
s.resource_bundles = {
s.module_name => 'PrivacyInfo.xcprivacy',
}
Comment on lines +33 to +35
Copy link

@ncooke3 ncooke3 Mar 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HannahShiSFB, because the resource bundle is at the root of the podspec, it will not get pulled down when clients like Firebase depend on subspecs of the pod (example).

See the approach taken in grpc/grpc#35542 and google/GoogleUtilities#144.

The subspecs in this spec look to be generated (example spec that has been published).

I can think of a few options to fix this:

  1. Add a new subspec with the privacy manifest and make it a dependency of all other subspecs.
  2. Wrap the existing bundle declaration in a subspec that clients like Firebase would manually point to in our podpspecs
  3. Throw the resource bundle in the base subspec's config subspec (abseil/base/config) because that nested config subspec looks to be a core dependency of many other subspecs.

Then, releasing a patch fix will be needed with any necessary backporting, and should also include changes from the unrelated #1639.

s.module_name = 'absl'
s.header_mappings_dir = 'absl'
s.header_dir = 'absl'
Expand Down