A new function, many typos fixing, and code re-formatting #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhengqiaoWang
requested changes
Jan 28, 2023
SRM/__init__.py
Outdated
| @@ -0,0 +1 @@ | |||
| from SRM import monitor | |||
There was a problem hiding this comment.
我记得从python3开始应该就不需要配置__init__.py设置包了吧？
SRM/monitor.py
Outdated
| @@ -1,11 +1,14 @@ | |||
| import psutil | |||
| import common | |||
| # -*- coding: UTF-8 -*- | |||
| help="限制监听范围，为进程名(如explorer.exe)", default=[]) | ||
| argparser.add_argument("-m", "--mail", type=bool, | ||
| help="是否发送邮件通知", default=False) | ||
|
|
There was a problem hiding this comment.
项目目录下添加一个配置文件吧。在配置文件里进行邮件的配置。尽量避免修改代码
There was a problem hiding this comment.
已经修改，详见下列：
- 在SRM包中单独创建了一个MAIL类来使用邮件通知；
- 用户可以通过指令输入相关配置；
start.py中仅有两行代码
另外，我希望之后能以修饰器的方式注入，目前看来改动较大
There was a problem hiding this comment.
修饰器也是一种表现形式，前提是需要将事件提出来，再提供事件注册接口，再然后是使用修饰器去注册。我觉得这个思路没问题，就是没时间去做，你可以试一试
There was a problem hiding this comment.
修饰器也是一种表现形式，前提是需要将事件提出来，再提供事件注册接口，再然后是使用修饰器去注册。我觉得这个思路没问题，就是没时间去做，你可以试一试
现在我也没时间了，毕业论文3月10号要交，等这段忙完吧
start.py
Outdated
|
|
||
| print("结果输出到：", os.path.abspath(args.output)) | ||
| if args.mail: |
There was a problem hiding this comment.
这个地方可能有问题。因为结束是需要用户出发或者通过其他方式发送INT信号的。
我觉得可以考虑将监控封装成几个标准事件，然后通过传入注册回调的方式实现功能自定义。
比如：
- 被监控进程退出事件（必须是手动指定进程名的模式）
- 被监控进程开启事件（必须是手动指定进程名的模式）
- 第N次扫描事件
然后邮件的内容可能需要简介。咱们可能需要设计一个简单的模板页面，用于邮件的发送。越想越复杂啊。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I re-formatted the code of your project, and fixed lots of typos.
Moreover, I added a email notice function, it needs a new package
iMail.Happy New Years!