Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: canbus updates #3

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: canbus updates #3

wants to merge 6 commits into from

Conversation

AlejoPm03
Copy link
Member

  • Handle send message error
  • Send status message

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Jul 16, 2024 •
edited
Loading

🧙 Sourcery has finished reviewing your pull request!

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot]
sourcery-ai bot reviewed Jul 16, 2024
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

joaoantoniocardoso
joaoantoniocardoso reviewed Jul 20, 2024
View reviewed changes
firmware/Core/Src/canbus.c
static uint32_t mailbox;

/* Check if mailbox is full*/
if (HAL_CAN_GetTxMailboxesFreeLevel(canbus.hcan) == 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (HAL_CAN_GetTxMailboxesFreeLevel(canbus.hcan) == 1)
if (HAL_CAN_GetTxMailboxesFreeLevel(canbus.hcan) == 0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlejoPm03 @joaoantoniocardoso