Feature/refactor capturing #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te them from Expressions
kindlich
force-pushed
the
feature/refactor-capturing
branch
from
e607ae4 to
c2fd879
Compare
kindlich
commented
Sep 14, 2024
| final JavaExpressionVisitor lambdaBodyVisitor = new JavaLambdaBodyCapturingExpressionVisitor(context, module, functionWriter, javaMangler, className, expression); | ||
| final JavaStatementVisitor capturedStatementVisitor = new JavaStatementVisitor(context, lambdaBodyVisitor, javaMangler); | ||
| expression.body.accept(capturedStatementVisitor); | ||
| JavaExpressionVisitor withCapturedExpressionVisitor = new JavaExpressionVisitor( |
There was a problem hiding this comment.
💭 Thought: Who doesn't like a bit of nesting?
| @@ -1,5 +1,4 @@ | |||
| #disabled: Not part of the refactor | |||
| #output: 8 | |||
| #output: 4 | |||
There was a problem hiding this comment.
❓ Was this test wrong before?
stanhebben
approved these changes
Oct 4, 2024
stanhebben
merged commit 63ee904
into
feature/refactor-fix-more-tests
0 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #173