Remove Array constructor that projected another array #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be handled by stdlib.Arrays.zs#map We decided against these two array constructors because they were the only usecase currently where a constructor would require a generic argument. Since this would make calls more complicated (generic class with generic constructor), it was decided that these ctors should be removed and constructors should not be made generic.
stanhebben
merged commit 97ae3f5
into
feature/refactor-data-flow-analysis
0 of 2 checks passed
kindlich
deleted the
feature/refactor-data-flow-analysis-remove-array-projection-constructor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be handled by stdlib.Arrays.zs#map
We decided against these two array constructors because they were the only usecase currently where a constructor would require a generic argument. Since this would make calls more complicated (generic class with generic constructor), it was decided that these ctors should be removed and constructors should not be made generic.