Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing AudioStreamSettings strings #626

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

3x1t-5tyl3
Copy link

These seem to be around for quite a while now and seem to be forgotten in the base locale?
Updated them.
Unless I happened to have missed the memo that these shouldn't be there.

image

@Frooxius
Copy link
Member

Frooxius commented Jan 9, 2025

Oh good catch! Hmm... The default bitrate is okay to have in settings, but I'm actually not sure if we should display the default device ID, since that's not very user friendly way to edit it.

The setting is used by the audio spawner. We might need to deal with this a bit and decide what to do first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants